Page MenuHomePhabricator
Create Task
Maniphest T361979

Extra line break is added when tagging redirects with redirect category tags
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Log out
  • Create a redirect (with no line breaks anywhere, e.g. #REDIRECT [[Test]]
  • Log in as admin
  • Visit redirect
  • PageTriage -> tags menu -> tag it with a redirect maintenance tag

What happens?:

image.png (507×690 px, 28 KB)

What should have happened instead?:

image.png (458×671 px, 27 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Removes extra line break on tagging redirects with maintenance tagsmediawiki/extensions/PageTriagemaster+6 -5
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Apr 5 2024, 9:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2024, 9:02 PM
Novem_Linguae moved this task from Backlog to Other bugs on the PageTriage board.Apr 5 2024, 9:03 PM
Novem_Linguae moved this task from Other bugs to Tagging wikicode bugs on the PageTriage board.Apr 6 2024, 12:02 AM
Novem_Linguae updated the task description. (Show Details)Apr 7 2024, 6:19 PM
Rockingpenny4 claimed this task.Apr 12 2024, 1:23 PM
gerritbot added a comment.Apr 12 2024, 9:55 PM

Change #1019359 had a related patch set uploaded (by Rockingpenny4; author: Rockingpenny4):

[mediawiki/extensions/PageTriage@master] Removes extra line break on tagging redirects with maintenance tags

https://gerrit.wikimedia.org/r/1019359

gerritbot added a project: Patch-For-Review.Apr 12 2024, 9:55 PM
Rockingpenny4 added a comment.Apr 12 2024, 9:57 PM

Made a patch for this bug. Here's the relevant screencast:

Soda renamed this task from Extra line break is added when tagging redirects with maintenance tags to Extra line break is added when tagging redirects with redirect category tags.Apr 20 2024, 5:03 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptApr 20 2024, 5:03 PM
gerritbot added a comment.Apr 22 2024, 6:50 AM

Change #1019359 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Removes extra line break on tagging redirects with maintenance tags

https://gerrit.wikimedia.org/r/1019359

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 22 2024, 7:01 AM
• Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Apr 23 2024, 12:20 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:01 PM
Soda closed this task as Resolved.Thu, May 16, 5:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL