Page MenuHomePhabricator

Blame doesn't work properly for queries with spaces
Open, Needs TriagePublic

Description

The Blame feature works great, I love using it. However, it seems to only consistently work for queries that are a single word. Phrases with spaces don't show results that I'd expect.

Take for example this search for the phrase "unnamed space marine" in [[Doom (franchise)]]: https://xtools.wmcloud.org/blame/en.wikipedia.org/Doom%20%28franchise%29/?q=unnamed%20space%20marine

Expected: We get at least one result, since this phrase exists in the current version of the article (and has existed sufficiently long that replica lag is not a factor).

Actual: No results.

If you instead search for "unnamed" you will get a ton of accurate results, but requires more work because the search is less specific. In this case, we can see this text was added on 2016-02-15.

Here's another example: searching for "unnamed space" on the same article: https://xtools.wmcloud.org/blame/en.wikipedia.org/Doom%20%28franchise%29/?q=unnamed%20space

Expected: All diffs shown in the results actually contain the string being searched.

Actual: Multiple results, including the first at https://en.wikipedia.org/wiki/Special:Diff/696846313, don't even contain the string "unnamed space".

XTools version: 3.18.8-0feb19a3