Page MenuHomePhabricator

Remove old/unused/internal methods in rdbms library from the public APIs
Open, MediumPublic

Description

The last leg of WE3.2.1 hypo work.

These changes mean in some cases we should soft-deprecate the method, sometimes hard-deprecate, sometimes complete removal, sometimes removing from the interface while keeping it in the class (to hide it to the outside of rdbms lib), and some cases, only mark them @internal in documentation.
Candidates for such changes are:

  • ISQLPlatform::limitResult()
  • ISQLPlatform::buildLike()
  • ISQLPlatform::unionQueries()
  • IReadableDatabase::lastErrno()
  • IReadableDatabase::selectField()
  • IReadableDatabase::selectFieldValues()
  • IReadableDatabase::selectRow()
  • IReadableDatabase::estimateRowCount()
  • IReadableDatabase::selectRowCount()
  • IReadableDatabase::databasesAreIndependent()
  • IReadableDatabase::selectDomain()
  • IReadableDatabase::wasDeadlock()
  • IReadableDatabase::wasReadOnlyError()
  • IReadableDatabase::primaryPosWait()
  • IReadableDatabase::getReplicaPos()
  • IReadableDatabase::getSessionLagStatus()
  • IDatabase::getTopologyBasedServerId()
  • IDatabase::getTopologyRole()
  • IDatabase::lastDoneWrites()
  • IDatabase::writesPending()
  • IDatabase::writesOrCallbacksPending()
  • IDatabase::pendingWriteQueryDuration()
  • IDatabase::pendingWriteCallers()
  • IDatabase::lockForUpdate()
  • IDatabase::nextSequenceValue()
  • IDatabase::getPrimaryPos()
  • IDatabase::serverIsReadOnly()
  • IDatabase::setTransactionListener()
  • IDatabase::flushSession()
  • IDatabase::lockIsFree()
  • IDatabase::namedLocksEnqueue()
  • ILoadBalancer::reuseConnection()
  • ILoadBalancer::getConnectionRef()
  • ILoadBalancer::getServerConnection()
  • ILoadBalancer::getConnectionInternal()
  • ILoadBalancer::getWriterIndex()
  • ILoadBalancer::laggedReplicaUsed()
  • ILoadBalancer::getReadOnlyReason()
  • ILBFactory::newMainLB()
  • ILBFactory::newExternalLB()
  • ILBFactory::getAllMainLBs()
  • ILBFactory::getAllExternalLBs()
  • ILBFactory::hasPrimaryChanges()
  • ILBFactory::laggedReplicaUsed()
  • ILBFactory::disableChronologyProtection()
  • ILBFactory::setAgentName()
  • ILBFactory::setIndexAliases()

Event Timeline

Ladsgroup triaged this task as Medium priority.Tue, Apr 30, 3:24 PM
Ladsgroup moved this task from Triage to In progress on the DBA board.

Change #1025809 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove IReadableDatabase::getReplicaPos()

https://gerrit.wikimedia.org/r/1025809

Change #1025813 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move ILoadBalancer::laggedReplicaUsed() to ILoadBalancerForOwner

https://gerrit.wikimedia.org/r/1025813

Change #1025809 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove IReadableDatabase::getReplicaPos()

https://gerrit.wikimedia.org/r/1025809

Change #1025813 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move ILoadBalancer::laggedReplicaUsed() to ILoadBalancerForOwner

https://gerrit.wikimedia.org/r/1025813

Change #1029227 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove IDatabase::namedLocksEnqueue()

https://gerrit.wikimedia.org/r/1029227

Change #1029228 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove IDatabase::getTopologyBasedServerId()

https://gerrit.wikimedia.org/r/1029228

Change #1029227 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove IDatabase::namedLocksEnqueue()

https://gerrit.wikimedia.org/r/1029227

Change #1029228 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove IDatabase::getTopologyBasedServerId()

https://gerrit.wikimedia.org/r/1029228

Change #1031845 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Introduce IDatabaseForOwner

https://gerrit.wikimedia.org/r/1031845

Change #1031869 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop IDatabase::getTopologyRole()

https://gerrit.wikimedia.org/r/1031869