Page MenuHomePhabricator

[Test regression] Citoid breaks Cite browser tests
Closed, ResolvedPublic

Description

For example, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/1023055 shows failures from ve-cite/veCiteIntegration.cy.js and ve-cite/templates.cy.js because the Citoid dialog structure differs from the Cite dialog and helpers such as openVECiteReuseDialog fail to find their targets:

12:58:40   1) Visual Editor Cite Integration
12:58:40        should display existing references in the Cite re-use dialog:
12:58:40      AssertionError: Timed out retrying after 5000ms: Expected to find element: `.ve-ui-toolbar-group-cite`, but never found it.
12:58:40       at Object.openVECiteReuseDialog (webpack:///./e2e/utils/functions.helper.js:102:5)

and

12:58:13   1) Re-using refs in Visual Editor using templates
12:58:13        should add a template reference and verify correct content in both saved and edit mode:
12:58:13      AssertionError: Timed out retrying after 5000ms: Expected to find content: 'Cite' within the selector: '.oo-ui-labelElement-label' but never did.
12:58:13       at Context.eval (webpack:///./e2e/tests/ve-cite/templates.cy.js:76:5)

Fix by making these tests conditional, or if possible making them robust enough to work under either environment.

Event Timeline

Change #1028803 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Temporarily skip tests incompatible with Citoid

https://gerrit.wikimedia.org/r/1028803

Change #1028803 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Temporarily skip tests incompatible with Citoid

https://gerrit.wikimedia.org/r/1028803

Change #1032625 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] Citoid breaks Cite browser tests

https://gerrit.wikimedia.org/r/1032625

Change #1032625 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Citoid breaks Cite browser tests

https://gerrit.wikimedia.org/r/1032625

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2024-05-08 board.
WMDE-Fisch removed a project: Patch-For-Review.
WMDE-Fisch added a subscriber: MareikeHeuerWMDE.