Page MenuHomePhabricator

Pressing Enter in "Preview page with this template" saves the edit instead of previewing
Closed, InvalidPublicBUG REPORT

Description

Steps to replicate the issue:

  • Enable "Show preview without reloading the page" in Preferences
  • Start editing a template or module
  • Enter a page name in the textbox below "Preview page with this template"
  • Press Enter/Return

What happens?:
The edit is submitted (saved if modified).

What should have happened instead?:
Live preview.

Other information:
Not reproducible with safemode=1, I may have jumped the gun. Still the handler not attached to the <input> element itself is potentially an issue.

Event Timeline

Change #1029855 had a related patch set uploaded (by Nardog; author: Nardog):

[mediawiki/extensions/TemplateSandbox@master] Attach live preview handler to the input element

https://gerrit.wikimedia.org/r/1029855

Nardog removed a project: Patch-For-Review.

Change #1029855 abandoned by Nardog:

[mediawiki/extensions/TemplateSandbox@master] Attach live preview handler to the input element

Reason:

https://gerrit.wikimedia.org/r/1029855

Test wiki on Patch demo by Nardog using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9cba001243/w/