Special:Investigate ComparePager should display total actions for the IP instead of edits
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Tue, May 14, 10:05 PM

Description

Special:Investigate 'IP & User agents' mode displays the total number of actions performed by the specific row (unique user, IP, and user agent combination), and also the number of actions performed by all users on that IP address. This is similar to the data displayed in Special:CheckUser 'Get IP Addresses' and is shown below:

However, while the count is labelled with the word actions, the counts are inconsistent with each other and also are labelled incorrectly. The total actions by the specific row is the count of all log entries and edits (excluding StructuredDiscussions edits), but the total from the IP count is a count of only edits (excluding StructuredDiscussions edits). The restriction to specific actions seems relatively arbitrary, considering that the filtering out of StructuredDiscussions edits is not applied by the 'Timeline' mode.

Updating the code to remove the restriction of what actions are used to generate the count should reduce confusion and bring the meanings of this data inline with the meaning in Special:CheckUser.

Acceptance criteria

Remove the conditions on cuc_type in the 'IP & User agents' tab

Details

	Subject	Repo	Branch	Lines +/-
	Include all actions for total actions count in the Compare tab	mediawiki/extensions/CheckUser	master	+49 -74

Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Tue, May 14, 10:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, May 14, 10:05 PM

Dreamy_Jazz set the point value for this task to 1.Tue, May 14, 10:06 PM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.

Change #1031578 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Include all actions for total actions count in the Compare tab

https://gerrit.wikimedia.org/r/1031578

gerritbot added a project: Patch-For-Review.Tue, May 14, 10:30 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.Tue, May 14, 10:32 PM

Dreamy_Jazz claimed this task.Tue, May 14, 11:30 PM

Change #1031578 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Include all actions for total actions count in the Compare tab

https://gerrit.wikimedia.org/r/1031578

Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.Wed, May 15, 5:48 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Wed, May 15, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, May 15, 6:30 PM

Suggested QA steps for patch demo:

Login to an account
Make an edit
Move a page
Log out of the account
Login to a different account that has the checkuser group
Move a page
Open Special:Investigate and run a check on the account you logged into in step 2
Verify that the actions count displayed in bold is 2 and that the number in italics is 3, as shown in the screenshot below:

{F53936868}

These steps are testing that all events are included in the counts that are shown in this column (not just edits).

Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.Mon, May 20, 6:19 PM

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You for the QA Steps @Dreamy_Jazz!!!

Dreamy_Jazz closed this task as Resolved.Tue, May 21, 12:56 PM

Dreamy_Jazz updated the task description. (Show Details)

	F54011306: image.png
	Tue, May 21, 2:12 AM

	F53998386: image.png
	Tue, May 21, 2:12 AM

	F53996410: image.png
	Tue, May 21, 2:12 AM

	Restricted File
	Mon, May 20, 10:34 AM

Special:Investigate ComparePager should display total actions for the IP instead of editsClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Acceptance criteria

Details

Event Timeline

Special:Investigate ComparePager should display total actions for the IP instead of edits
Closed, ResolvedPublic1 Estimated Story Points
Actions