Page MenuHomePhabricator
Create Task
Maniphest T53569

Reduce number of load.php calls on VisualEditor open (down from 3)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

On a regular page load:

We get this (did a full analysis while I had the data in front of me, but focus on "On Edit":

Top:

  • [core] load.php?modules=startup
  • [misc] load.php?modules=.. top queue ...
  • [vector] load.php?modules=ext.vector.footerCleanup (bug 51564)
  • [ve] load.php?modules=ext.visualEditor.viewPageTarget.init
  • [core] load.php?modules=site

Bottom:

  • [misc] load.php?modules=.. bottom queue ...
  • [vector] load.php?modules=ext.vector.collapsibleNav (bug 51564)
  • [misc] load.php?modules=.. jquery.ui ... (dependency of something in the bottom queue, separate cache group)

On Edit:

  • [ve] load.php?modules=ext.visualEditor.base,mediawiki,viewPageTarget|jquery.visibleText|oojs|unicodejs.wordbreak
  • [ve] load.php?modules=jquery.byteLength,byteLimit|mediawiki.api.edit|mediawiki.feedback|ext.visualEditor.core,icons-vector|ext.visualEditor.viewPageTarget.icons-vector|rangy
  • [ve] load.php?modules=ext.visualEditor.specialMessages
  • [ve] api.php POST action=visualeditor & paction=parse
  • [ve] api.php?action=query&meta=userinfo

These shouldn't be 3 separate load.php requests. Ideally it'd be 1, but we should at least cut it down to 2. We should figure out why they are split.

Details

Reference
bz51569
SubjectRepoBranchLines +/-
Load RL modules in one load.php request, rather than in two stagesmediawiki/extensions/VisualEditormaster+163 -130
Load RL modules in one load.php request, rather than in two stagesmediawiki/extensions/VisualEditorwmf/1.25wmf21+163 -130
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:42 AM
• bzimport added a project: Technical-Debt.
• bzimport set Reference to bz51569.
Krinkle created this task.Jul 17 2013, 7:26 PM
Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 6:27 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Nov 24 2014, 6:41 PM
Jdforrester-WMF renamed this task from VisualEditor: Reduce number of load.php on edit (down from 3) to Reduce number of load.php calls on VisualEditor open (down from 3).Dec 2 2014, 9:40 PM
Jdforrester-WMF added projects: VisualEditor-Performance, Performance Issue.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 2 2015, 8:05 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:01 PM
• TrevorParscal edited a custom field.Feb 4 2015, 7:12 PM
Jdforrester-WMF updated the task description. (Show Details)Feb 21 2015, 12:00 AM
Catrope claimed this task.Feb 25 2015, 11:10 PM
Catrope edited a custom field.
Catrope moved this task from Backlog to Doing on the VisualEditor-Performance board.
gerritbot subscribed.Mar 2 2015, 9:12 PM

Change 193026 had a related patch set uploaded (by Jforrester):
[WIP] Factor out loading code into TargetLoader

https://gerrit.wikimedia.org/r/193026

gerritbot added a project: Patch-For-Review.Mar 2 2015, 9:12 PM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Mar 12 2015, 5:41 PM
Krinkle added a comment.EditedMar 15 2015, 1:26 AM

Saves 1 request and 3KB.

From 20 total request (521KB), to 19 total requests (518KB).

Tested on localhost. (Page view + load editor; includes two EventLogging requests and some images).

gerritbot added a comment.Mar 15 2015, 3:03 AM

Change 193026 merged by jenkins-bot:
Load RL modules in one load.php request, rather than in two stages

https://gerrit.wikimedia.org/r/193026

Jdforrester-WMF closed this task as Resolved.Mar 15 2015, 3:04 AM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 15 2015, 3:20 AM
gerritbot added a comment.Mar 17 2015, 8:02 PM

Change 197402 had a related patch set uploaded (by Jforrester):
Load RL modules in one load.php request, rather than in two stages

https://gerrit.wikimedia.org/r/197402

gerritbot added a project: Patch-For-Review.Mar 17 2015, 8:02 PM
gerritbot added a comment.Mar 17 2015, 9:01 PM

Change 197402 merged by jenkins-bot:
Load RL modules in one load.php request, rather than in two stages

https://gerrit.wikimedia.org/r/197402

ori moved this task from Doing to Done on the VisualEditor-Performance board.Mar 19 2015, 9:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 20 2015, 11:32 PM
Krinkle mentioned this in rEVEDd371014e5dfe: Load RL modules in one load.php request, rather than in two stages.Mar 23 2015, 3:54 PM
Jdforrester-WMF mentioned this in rEVEDe823d7b60189: Load RL modules in one load.php request, rather than in two stages.Mar 23 2015, 3:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL