Version doesn't exist if author or summary of revision is hidden (FlaggedRevs conflicts with revision deletion)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• bzimport
	Oct 5 2013, 3:40 PM

Description

Author: wojciech.r

Description:
https://www.mediawiki.org/w/index.php?title=Manual:Redirects&oldid=579487&diff=cur
I can't accept this revision because its author is hidden. It shows that this revision doesn't exist. I think it should still be available to review this edit, even if the author is hidden.

Details

Reference: bz55349

	Subject	Repo	Branch	Lines +/-
	RevisionReviewForm.php: Only check is the revision text is deleted	mediawiki/extensions/FlaggedRevs	master	+1 -1
	RevisionRecord.php: Add ability to check whether the revision text can be seen	mediawiki/core	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned Here: T100360: Revision after deleted revision can't be reviewed (Flagged Revs)

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:36 AM

• bzimport added a project: MediaWiki-Revision-deletion.

• bzimport set Reference to bz55349.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Oct 5 2013, 3:40 PM

I'm not sure if I understand correctly the steps to reproduce and what you try to do. Do you try to re-review the revision?

On the link above I see "Revision as of 19:58, 3 September 2012" and
"Latest revision as of 12:18, 7 October 2013", plus
"(One intermediate revision by one user not shown)"

Oh wait, is this the same as bug 55360?

wojciech.r wrote:

Yes

Bug 55360 has been marked as a duplicate of this bug. ***

Umherirrender merged a task: T85524: Cannot approve revision with revision deleted comment.Jan 2 2015, 3:29 PM

Umherirrender added a project: MediaWiki-extensions-FlaggedRevs.

Umherirrender added subscribers: Aklapper, Umherirrender.

Umherirrender merged a task: T42599: Hiding user of latest unflagged page revision causes it to become unreviewable.Jan 2 2015, 3:31 PM

Umherirrender added a subscriber: matmarex.

Nemo_bis lowered the priority of this task from Medium to Low.Apr 26 2015, 5:48 PM

Nemo_bis set Security to None.

Problems also on hidden edit summary: T100360

Catrope unsubscribed.Jan 14 2016, 7:37 PM

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptJan 14 2016, 7:37 PM

Actually, T100360 is about deleted revision, but with deleted edit summary the situation is really the same.
Example: https://hu.wikipedia.org/w/index.php?title=S%C3%BClys%C3%A1p&curid=45101&diff=19117621&oldid=19117618

jeremyb subscribed.Oct 2 2017, 4:08 PM

jeremyb merged a task: T57360: FlaggedRevs conflicts with revision deletion.Oct 2 2017, 4:17 PM

jeremyb added a subscriber: • MZMcBride.

Krinkle unsubscribed.Jan 23 2018, 1:18 AM

Umherirrender unsubscribed.Feb 27 2021, 10:09 PM

tsca subscribed.Oct 19 2022, 1:12 PM

matmarex merged a task: T100360: Revision after deleted revision can't be reviewed (Flagged Revs).Dec 16 2022, 9:25 AM

matmarex merged a task: T325171: Impossible to approve a version if a sysop hided the author of the version.

matmarex added subscribers: MBH, 1234qwer1234qwer4, Base and 2 others.

matmarex added subscribers: William_Cheselden, DannyS712, Caenus, Ladsgroup.

Tacsipacsi renamed this task from Version doesn't exists if author of revision is hidden (FlaggedRevs conflicts with revision deletion) to Version doesn't exist if author of revision is hidden (FlaggedRevs conflicts with revision deletion).Dec 16 2022, 9:30 AM

Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".

Tacsipacsi updated the task description. (Show Details)

Tacsipacsi edited subscribers, added: Tacsipacsi; removed: • wikibugs-l-list.

1234qwer1234qwer4 renamed this task from Version doesn't exist if author of revision is hidden (FlaggedRevs conflicts with revision deletion) to Version doesn't exist if author or summary of revision is hidden (FlaggedRevs conflicts with revision deletion).Dec 16 2022, 11:54 AM

Change 868843 had a related patch set uploaded (by Caenus; author: Caenus):

[mediawiki/core@master] RevisionRecord.php: Add ability to check whether the revision text can be seen

https://gerrit.wikimedia.org/r/868843

gerritbot added a project: Patch-For-Review.Dec 18 2022, 7:17 PM

Change 868844 had a related patch set uploaded (by Caenus; author: Caenus):

[mediawiki/extensions/FlaggedRevs@master] RevisionReviewForm.php: Only check is the revision text is deleted

https://gerrit.wikimedia.org/r/868844

Change 868843 abandoned by Caenus:

[mediawiki/core@master] RevisionRecord.php: Add ability to check whether the revision text can be seen

Reason:

better https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/868844/

https://gerrit.wikimedia.org/r/868843

William_Cheselden moved this task from Backlog to Under review on the MediaWiki-extensions-FlaggedRevs board.Dec 19 2022, 9:51 AM

Change 868844 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] RevisionReviewForm.php: Only check is the revision text is deleted

https://gerrit.wikimedia.org/r/868844

Maintenance_bot removed a project: Patch-For-Review.Dec 27 2022, 11:30 AM

William_Cheselden moved this task from Under review to Done on the MediaWiki-extensions-FlaggedRevs board.Dec 27 2022, 11:33 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 27 2022, 12:00 PM

Thank you for the patch!

The fix will be deployed to Wikimedia wikis next week, 3-5 January, per the usual schedule.

Aklapper moved this task from Done to Under review on the MediaWiki-extensions-FlaggedRevs board.Jan 2 2023, 4:57 PM

Caenus reopened this task as Open.Jan 4 2023, 11:00 AM

Caenus updated the task description. (Show Details)

Caenus closed this task as Resolved.Jan 4 2023, 11:26 AM