Thumbnails in table caption get hoisted outside the table
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Etonkovidova
	Nov 26 2014, 10:27 PM

Description

Testcase: http://en.wikipedia.beta.wmflabs.org/wiki/T76100_test

Steps to reproduce:

VE - insert a table and add a caption.
click in the Caption and type some text and then Insert Media ->the inserted media will be placed inside of the Caption boundaries(a border with thin grey line).

Save the page - the image gets de-attached from a table's caption(the screenshots are attached).

VE_table_caption_with_Inserted_media.png (346×694 px, 46 KB)

caption_with_Media_after_Save.png (343×717 px, 51 KB)

Related Objects

Duplicates Merged Here: T154163: mw.html:wikitext doesn't set expected value

Event Timeline

Etonkovidova created this task.Nov 26 2014, 10:27 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a project: VisualEditor-ContentEditable.

Etonkovidova changed Security from none to None.

Etonkovidova subscribed.

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:41 AM

Krenair subscribed.Nov 28 2014, 1:43 AM

Liuxinyu970226 subscribed.Nov 28 2014, 3:48 AM

This is a Tidy issue – doesn't happen with $wgUseTidy = false. Doesn't happen with Parsoid, either.

Can be reproduced with the following wikitext:

{| class="wikitable"
|+ Caption [[File:Example.jpg|thumb]] more caption
|-
| table cell
|}

The thumbnailed image and the text "more caption" are hoisted out of the table caption to a separate paragraph before the table.

http://en.wikipedia.beta.wmflabs.org/wiki/T76100_test

(Using just [[File:Example.jpg]] doesn't show the problem.)

Aklapper triaged this task as Low priority.Dec 29 2014, 11:19 PM

Aklapper subscribed.

Liuxinyu970226 unsubscribed.Dec 30 2014, 1:17 AM

Danny_B added a project: Tidy.May 28 2016, 10:31 AM

Danny_B removed a parent task: T4542: [DO NOT USE] HTML Tidy issues (tracking) [superseded by the #Tidy tag].May 28 2016, 10:50 AM

Anomie merged a task: T154163: mw.html:wikitext doesn't set expected value.Dec 26 2016, 8:48 PM

Anomie added a subscriber: eranroz.

Seems like the upstream bug is https://github.com/htacg/tidy-html5/issues/196 ?
If so it is fixed since Apr 2015.

If that's the right upstream ticket this should be fixed in version 4.9.28. Now which version of Tidy are we running on servers...? In any case: Still an issue.

Aklapper updated the task description. (Show Details)Apr 20 2017, 4:35 PM

MattFitzpatrick closed this task as a duplicate of T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.Sep 18 2017, 11:27 PM

	F16578: caption_with_Media_after_Save.png
	Nov 26 2014, 10:27 PM

	F16576: VE_table_caption_with_Inserted_media.png
	Nov 26 2014, 10:27 PM

Thumbnails in table caption get hoisted outside the tableClosed, DuplicatePublicActions

Description

Related Objects

Event Timeline

Thumbnails in table caption get hoisted outside the table
Closed, DuplicatePublic
Actions