Page MenuHomePhabricator
Create Task
Maniphest T87156

Closing mobile media viewer always scrolls to top on FF, IE
Closed, ResolvedPublic
Actions

Description

The previous scroll position is not restored. No console messages. The problem does not occur in Chromium or on the desktop site.

Details

SubjectRepoBranchLines +/-
Restore document scroll position after closing the overlaymediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

tstarling created this task.Jan 18 2015, 11:00 PM
tstarling raised the priority of this task from to Needs Triage.
tstarling updated the task description. (Show Details)
tstarling added a project: MediaViewer.
tstarling subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 18 2015, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr subscribed.Jan 18 2015, 11:50 PM

*.m.* uses the mobile viewer, a separate product.

Tgr edited projects, added Web-Team-Backlog; removed Multimedia, MediaViewer.Jan 18 2015, 11:51 PM
Tgr set Security to None.
Florian subscribed.Jan 19 2015, 12:25 AM
tstarling renamed this task from Closing MMV always scrolls to top on *.m.wikipedia.org on FF, IE to Closing mobile media viewer always scrolls to top on FF, IE.Jan 19 2015, 2:44 AM
Jdlrobson subscribed.EditedJan 19 2015, 7:18 PM

This might be a generic problem with overlay scrolling. The same might happens for the talk overlay. Can someone investigate and verify locally? We've done a bunch of refactoring so it's possible this is fixed in latest master.

Maryana moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Jan 28 2015, 6:22 PM
Jdlrobson added a comment.Feb 2 2015, 5:19 PM

Strange. What is Chrome doing differently (as it's not an issue there)?

Tgr added a comment.Feb 2 2015, 9:35 PM

For the desktop product, we save/restore the scroll position from JS.

Jdlrobson added a comment.Feb 2 2015, 9:54 PM

We do on mobile too.. for some reason only applying in Chrome though.

• bmansurov claimed this task.Feb 4 2015, 10:12 PM
gerritbot added a project: Patch-For-Review.Feb 4 2015, 10:32 PM
gerritbot subscribed.

Change 188681 had a related patch set uploaded (by Bmansurov):
Restore document scroll position after closing the overlay

https://gerrit.wikimedia.org/r/188681

Patch-For-Review

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Feb 4 2015, 10:32 PM
gerritbot added a comment.Feb 5 2015, 7:28 PM

Change 188681 merged by jenkins-bot:
Restore document scroll position after closing the overlay

https://gerrit.wikimedia.org/r/188681

• bmansurov mentioned this in rEMFRc4e06d9f5c37: Restore document scroll position after closing the overlay.Feb 5 2015, 7:28 PM
• bmansurov closed this task as Resolved.Feb 5 2015, 7:30 PM
Diffusion mentioned this in rMEXT5b2d7c6e6bea: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:25 AM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL