Page MenuHomePhabricator
Create Task
Maniphest T88483

Disabled button style not right
Closed, ResolvedPublic
Actions

Description

Screenshot_2015-02-03_13.28.52.png (259×288 px, 22 KB)

#FFF on icon and text
#DDD on button background

  • OOjs UI
  • mediawiki.ui (LESS)

Details

SubjectRepoBranchLines +/-
MediaWiki Theme: Use white icons for disabled buttonsoojs/uimaster+6 -8
mediawiki.ui: button: Use the correct background color for disabled buttonsmediawiki/coremaster+2 -2
MediaWiki Theme: Fix background color for disabled buttonsoojs/uimaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• violetto created this task.Feb 3 2015, 9:30 PM
• violetto assigned this task to • Prtksxna.
• violetto raised the priority of this task from to Needs Triage.
• violetto updated the task description. (Show Details)
• violetto added a project: UI-Standardization.
• violetto subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2015, 9:30 PM
• Prtksxna triaged this task as Medium priority.Feb 8 2015, 8:43 AM
• Prtksxna set Security to None.
gerritbot added a project: Patch-For-Review.Feb 11 2015, 12:54 PM
gerritbot subscribed.

Change 189945 had a related patch set uploaded (by Prtksxna):
MediaWiki Theme: Use white icons for disabled buttons

https://gerrit.wikimedia.org/r/189945

Patch-For-Review

gerritbot added a comment.Feb 11 2015, 12:54 PM

Change 189946 had a related patch set uploaded (by Prtksxna):
MediaWiki Theme: Fix background color for disabled buttons

https://gerrit.wikimedia.org/r/189946

Patch-For-Review

• Prtksxna mentioned this in T88449: Buttons differ between OOjs UI and mediawiki UI (tracking).Feb 11 2015, 12:56 PM
• Prtksxna mentioned this in T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast.Feb 11 2015, 1:28 PM
gerritbot added a comment.Feb 11 2015, 9:33 PM

Change 189946 merged by jenkins-bot:
MediaWiki Theme: Fix background color for disabled buttons

https://gerrit.wikimedia.org/r/189946

Jdforrester-WMF closed this task as Resolved.Feb 11 2015, 10:40 PM
Jdforrester-WMF edited projects, added OOUI, OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.7.0), WMF-deploy-2015-02-18_(1.25wmf18); removed OOjs-UI-next-release.Feb 12 2015, 12:28 AM
Ricordisamoa subscribed.Feb 12 2015, 8:37 AM
• violetto reopened this task as Open.Feb 12 2015, 9:55 PM

Screenshot_2015-02-12_13.53.57.png (68×273 px, 13 KB)

The icon on disabled buttons are still not white, reopening this task.

• Prtksxna updated the task description. (Show Details)Feb 13 2015, 5:25 AM
gerritbot added a project: Patch-For-Review.Feb 17 2015, 9:29 AM

Change 190996 had a related patch set uploaded (by Prtksxna):
mediawiki.ui: button: Use the correct background color for disabled buttons

https://gerrit.wikimedia.org/r/190996

Patch-For-Review

matmarex added a subtask: T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast.Feb 17 2015, 1:58 PM
gerritbot added a comment.Feb 17 2015, 2:00 PM

Change 190996 merged by jenkins-bot:
mediawiki.ui: button: Use the correct background color for disabled buttons

https://gerrit.wikimedia.org/r/190996

• Prtksxna mentioned this in rMW8f3d06719c91: mediawiki.ui: button: Use the correct background color for disabled buttons.Feb 17 2015, 2:00 PM
matmarex renamed this task from Disabled button color not right to Disabled button style not right.Feb 17 2015, 2:12 PM
matmarex closed subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Resolved.
gerritbot added a comment.Feb 17 2015, 2:25 PM

Change 189945 merged by jenkins-bot:
MediaWiki Theme: Use white icons for disabled buttons

https://gerrit.wikimedia.org/r/189945

matmarex closed this task as Resolved.Feb 17 2015, 2:26 PM
matmarex edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
matmarex removed a subscriber: gerritbot.
matmarex subscribed.

Should be all fixed now. If you spot any inconsistencies between OOUI and mediawiki.ui, let's put them on T88449.

Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Feb 17 2015, 3:37 PM
• violetto added a comment.Feb 17 2015, 10:36 PM

Thanks, saw the fixes they look great.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.8.0); removed OOjs-UI-next-release.Feb 19 2015, 9:35 PM
• Elitre awarded a token.Feb 23 2015, 6:33 PM
• Elitre subscribed.
• Prtksxna mentioned this in rGOJU529ac21ee170: MediaWiki Theme: Fix background color for disabled buttons.Mar 3 2015, 7:50 PM
matmarex mentioned this in rGOJU01c87afac5d0: MediaWiki Theme: Use white icons for disabled buttons.Mar 3 2015, 7:50 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM
Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 9:00 PM
matmarex reopened subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Open.May 21 2016, 7:08 AM
Jdforrester-WMF closed subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Resolved.Sep 9 2016, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL