Maniphest T89506

Watchstar icons in alpha and beta not aligned
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Feb 13 2015, 10:49 PM

Tags

Referenced Files

	F40801: watchstar_bug.png
	Feb 13 2015, 10:49 PM

Subscribers

Description

See screenshot:

watchstar_bug.png (428×335 px, 31 KB)

Only affects alpha and beta currently. Reproducable on beta labs.

Details

	Subject	Repo	Branch	Lines +/-
	Don't add height to watchstar button	mediawiki/extensions/MobileFrontend	master	+0 -2

Customize query in gerrit

Related Objects

Mentioned In: rMEXTdfe267a80338: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRbf91a5b57041: Don't add height to watchstar button
Mentioned Here: T91178: Watchstars not aligned in search

Event Timeline

kaldari created this task.Feb 13 2015, 10:49 PM

kaldari raised the priority of this task from to Needs Triage.

kaldari updated the task description. (Show Details)

kaldari added a project: Web-Team-Backlog.

kaldari subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2015, 10:49 PM

kaldari moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Feb 13 2015, 10:49 PM

Change 190665 had a related patch set uploaded (by Florianschmidtwelzow):
Don't add height to watchstar button

https://gerrit.wikimedia.org/r/190665

Patch-For-Review

Florian claimed this task.Feb 14 2015, 7:47 PM

Change 190665 merged by jenkins-bot:
Don't add height to watchstar button

https://gerrit.wikimedia.org/r/190665

Florian mentioned this in rEMFRbf91a5b57041: Don't add height to watchstar button.Feb 16 2015, 5:45 PM

Florian closed this task as Resolved.Feb 16 2015, 5:46 PM

Just checked on beta labs and the stars are now misaligned in a different way :) The non-watched and watched ones line up now, which is good, but they're all floating too close to the top border of the search results box and not in the center, which is not so good.

Yup still broken!

Jdlrobson removed a project: Patch-For-Review.Feb 26 2015, 10:31 PM

Jdlrobson set Security to None.

This was before this change and in stable, too and is another problem, so i created anither task for it :) T91178: Watchstars not aligned in search

Florian closed this task as Resolved.Feb 28 2015, 11:06 PM

Florian removed a subtask: T91178: Watchstars not aligned in search.

Diffusion mentioned this in rMEXTdfe267a80338: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:26 AM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:21 AM