Page MenuHomePhabricator

wm-bot attempts to join channels before identifying causing invite only issues
Closed, DeclinedPublic

Description

I was letting a user know that there was an issue with their channel being invite only at http://en.wikipedia.org/wiki/User_talk:PhantomTech#wm-bot_and_.23.23PhantomTech when it occurred to me that it appears that the bot isn't waiting until it is identified before trying to join channels which is preventing it from joining channels since it is being reject by some channels. I may be totally off here, but I think that if the behavior of the bot is changed so it connects to the network, identifies, waits for confirmation and then joins channels there will be many fewer issues with this kind of thing.

Event Timeline

Technical13 assigned this task to Petrb.
Technical13 raised the priority of this task from to Needs Triage.
Technical13 updated the task description. (Show Details)
Technical13 added a project: WM-Bot.
Technical13 subscribed.

Example log of this issue (Due to the reboots on Labs today):

09:06:06 ⇐ +wm-bot3 quit (wm-bot@wikimedia/bot/wm-bot) Read error: Connection reset by peer
09:06:58 ⇐ +wm-bot5 quit (wm-bot@wikimedia/bot/wm-bot) Ping timeout: 256 seconds
09:06:58 ⇐ +wm-bot4 quit (wm-bot@wikimedia/bot/wm-bot) Ping timeout: 256 seconds
09:06:58 ⇐ +wm-bot quit (wm-bot@wikimedia/bot/wm-bot) Ping timeout: 256 seconds
09:06:58 ⇐ +wm-bot2 quit (wm-bot@wikimedia/bot/wm-bot) Ping timeout: 256 seconds
09:19:43 → wm-bot3 joined (wm-bot@wikimedia/bot/wm-bot)
09:19:43 +wm-bot3 was voiced (+v) by ChanServ
09:19:47 → wm-bot2 joined (wm-bot@wikimedia/bot/wm-bot)
09:19:47 +wm-bot2 was voiced (+v) by ChanServ
09:19:50 → wm-bot5121 joined (wm-bot@208.80.155.190)
09:19:54 → wm-bot26 joined (wm-bot@208.80.155.190)
09:19:54 → wm-bot4187 joined (wm-bot@208.80.155.190)
09:23:08 wm-bot5121 → wm-bot5
09:23:14 <wm-bot26> Join error: Cannot join channel (+i) - you must be invited channel: wm-bot5121 ##TheMesquito reason: InviteOnly
09:23:15 <wm-bot26> Join error: Cannot join channel (+i) - you must be invited channel: wm-bot5121 ##TheMesquito reason: InviteOnly
09:23:16 <wm-bot26> Join error: Cannot join channel (+i) - you must be invited channel: wm-bot5121 #wikipedia-ja-admins reason: InviteOnly
09:23:17 <wm-bot26> Join error: Cannot join channel (+i) - you must be invited channel: wm-bot5121 #wikipedia-ja-admins reason: InviteOnly
09:23:18 <wm-bot26> Join error: Cannot join channel (+b) - you are banned channel: wm-bot4187 ##cafeteria reason: Banned
09:23:18 <wm-bot26> Join error: Cannot join channel (+b) - you are banned channel: wm-bot4187 ##cafeteria reason: Banned

A reauth and a part/join fixed it.

bot is already doing that, it first authenticate and then it joins channels. These samples were probably from time when nickserv was down or lagged.

the part that bot doesn't do now is "wait for confirmation" but that means in case nickserv is down, it would never join