In English Wikipedia if I request the page image for File:Mahkama du Pacha.jpg I don't get one. Expected: The page image should be itself.
https://en.m.wikipedia.org/wiki/Special:ApiSandbox?useformat=desktop#action=query&prop=pageimages&format=json&piprop=thumbnail&titles=File%3AMahkama%20du%20Pacha.jpg
The page image should be itself.
Note: This impacts Gather collections: https://en.m.wikipedia.org/wiki/Special:Gather/id/657/May
ApiQueryPageImages#execute gets the titles it's going to work with from ApiPageSet#getGoodTitles, which discards, amongst others, all titles corresponding to foreign files.
However, ApiQueryPageImages#execute handles titles in filespace distinctly from titles in any other namespace. In fact, it defers to wfFindFile to both validate the title and fetch the corresponding file, if any, which is ideal. Therefore, we should only have to include missing filespace titles – using ApiPageSet#getMissingTitlesByNamespace – when we're processing filespace titles.
Change 242835 had a related patch set uploaded (by Phuedx):
Include foreign files in ApiQueryPageImages
A similar issue seems to impact TextExtracts. T114418
This change is working a charm on http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/id/167 - thanks!
This likely broke beta cluster: T114417: Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39 (only going off of changelog for pageimages repo)
Change 243124 had a related patch set uploaded (by Phuedx):
Revert "Revert "Include foreign files in ApiQueryPageImages""
Confirmed on beta labs http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/id/167
Have seen no significant spike in fatals this time (touch wood).