Page MenuHomePhabricator

Make a better keyboard shortcut for adding a citation
Closed, ResolvedPublic1 Estimated Story Points

Description

Making a citation is one of the major VE workflows that still doesn't have a keyboard shortcut (EDIT: <ref works, but my sense is that we don't want to advertise that to new users). One candidate is meta + option + f, which Microsoft Word has used for adding a footnote. However, this conflicts with Google Chrome's shortcut for "search the web".

Event Timeline

nshahquinn-wmf claimed this task.
nshahquinn-wmf raised the priority of this task from to Low.
nshahquinn-wmf updated the task description. (Show Details)
nshahquinn-wmf added a project: VisualEditor.
nshahquinn-wmf subscribed.

Let me share a little secret: you can trigger it by typing <ref. ;)

@matmarex, true :) But I don't think that's something we want to be advertising to new users.

nshahquinn-wmf renamed this task from Make a keyboard shortcut for adding a citation to Make a better keyboard shortcut for adding a citation.May 18 2015, 9:48 PM
nshahquinn-wmf set Security to None.
nshahquinn-wmf updated the task description. (Show Details)

Comments from T59452:

My first choice is ctrl-alt-r, which unfortunately is in use as a shortcut to open Special:RecentChanges, and command-R is in use by the browsers to reload pages.

I'll personally use this enough that I'll be able to get used to just about anything. Maybe ctrl-alt-1, if you want this to work across multiple languages? Adding citations has "number one" importance to many Wikipedia editors.

Let's avoid symbols not available on non-English keyboards for a start, like backslash :p

Ctrl-Alt must never be used for any keyboard shortcuts if you want the editor to work on non-US keyboard layouts, since it's equivalent to AltGr on Windows, and AltGr is often used to input special characters. For example, on the Polish keyboard layout, AltGr+A produces the 'ą' character (and there are eight more similar shortcuts for 'ć', 'ę', 'ł', 'ń', 'ó', 'ś', 'ź', and 'ż'). If you take over the shortcut, these characters become impossible to type.

@matmarex, do the existing keyboard shortcuts work with a Polish keyboard on a Mac? Control-alt is used by MediaWiki software for several browser/OS combinations in https://en.wikipedia.org/wiki/Wikipedia:Keyboard_shortcuts#Modifier_keys

They would probably mostly work for MediaWiki, since you still can use the combination, as long as you're not typing text in a text input. They wouldn't work for VisualEditor, since you're always typing text when using it.

But I actually don't see Ctrl+Alt listed for any browser on that page? (Note that MediaWiki doesn't control the combination, only the last key in it; the modifier keys are browser-dependent.)

"Option" is the same thing as "Alt" on a Mac keyboard.

Oh, sorry, I have no idea how Macs handle this. The behavior I described is, as far as I know, specific to Windows.

I guess that this is the next question: Can we use whatever modifier keys are normal for the browser/OS + r? Or should we do something else?

No, they're awkward. We should stick to what we were doing so far: either Ctrl+X or Ctrl+Shift+X (Cmd+X or Cmd+Shift+X on Mac OS).

The logic, incidentally, being that we already have the "add a link" shortcut as meta-k, and references are (to the end user) fairly conceptually similar to links, in that they're both "add a pointer to more information somewhere".

Plus, you know, it wasn't taken.

Jdforrester-WMF set the point value for this task to 0.
Jdforrester-WMF changed the point value for this task from 0 to 1.Nov 15 2016, 6:15 PM