Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2016

Glaisher closed T144042: Translate shows unsaved translations confirmation box even when there are no unsaved translations as Invalid.

Hmm, I wrongly assumed that clicking close discards all the unsaved translations. Actually, it doesn't in which case this is the right behavior.

Aug 29 2016, 3:53 AM · MediaWiki-extensions-Translate

Aug 28 2016

Glaisher added a subtask for T139810: RFC: Overhaul the CheckUser extension: T132892: CheckUser UI revamp.
Aug 28 2016, 5:03 PM · Goal, Epic, User-notice, WMF-Legal, Trust-and-Safety, Stewards-and-global-tools, CheckUser
Glaisher added a parent task for T132892: CheckUser UI revamp: T139810: RFC: Overhaul the CheckUser extension.
Aug 28 2016, 5:03 PM · Design, Stewards-and-global-tools, CheckUser

Aug 27 2016

Glaisher removed a project from T111837: Create more search fields in GlobalRenameQueue: Patch-For-Review.
Aug 27 2016, 4:15 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Stewards-and-global-tools, MediaWiki-extensions-CentralAuth, GlobalRename
Glaisher placed T111837: Create more search fields in GlobalRenameQueue up for grabs.
Aug 27 2016, 4:15 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Stewards-and-global-tools, MediaWiki-extensions-CentralAuth, GlobalRename
Glaisher updated subscribers of T47096: Add a way to transclude template or other page in the correct language.

E.g. a simple page like https://www.mediawiki.org/wiki/User:Scott is broken right now because someone localised "Interwiki redirect". It is not clear to me why <translate> can't simply return the default content by default instead of being rendered as literal text.

Aug 27 2016, 3:52 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate
Glaisher merged task T144048: Global user pages on Special:BrokenRedirects into T90978: Redirects to global user pages are broken, and added to Special:BrokenRedirects.
Aug 27 2016, 8:06 AM · Pywikibot-redirect.py, MediaWiki-Redirects, MediaWiki-Special-pages, GlobalUserPage
Glaisher merged T144048: Global user pages on Special:BrokenRedirects into T90978: Redirects to global user pages are broken, and added to Special:BrokenRedirects.
Aug 27 2016, 8:06 AM · GlobalUserPage, MediaWiki-Special-pages

Aug 26 2016

Glaisher created T144042: Translate shows unsaved translations confirmation box even when there are no unsaved translations.
Aug 26 2016, 6:00 PM · MediaWiki-extensions-Translate
Glaisher added a comment to T142840: tux does not prevent translations of source language when language is changed through language selector.

For the record, Wikimedia wikis recently removed English for all groups from TranslateBlacklist in https://gerrit.wikimedia.org/r/306015. That configuration should not be needed as Translate should do that check on it's own; it shouldn't need to depend on configuration).

Aug 26 2016, 5:55 PM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Translate

Aug 25 2016

Glaisher created T143858: Special:Translate in non-TUX mode without group specified shows weird page.
Aug 25 2016, 6:39 AM · MediaWiki-extensions-Translate
Glaisher moved T143855: tux doesn't let the user know about it if the language is a non-translatable language from Backlog to tux on the MediaWiki-extensions-Translate board.
Aug 25 2016, 5:50 AM · Language-2018-Apr-June, MediaWiki-extensions-Translate
Glaisher added projects to T143852: Caches stuck when uploading images with maintenance script: MediaWiki-Maintenance-system, MediaWiki-libs-BagOStuff.
Aug 25 2016, 5:49 AM · MediaWiki-libs-BagOStuff, MediaWiki-Maintenance-system
Glaisher added a project to T143851: New NAMESPACE for Azerbaijani Wiktionary: Wikimedia-Site-requests.
Aug 25 2016, 5:46 AM · Patch-For-Review, Wikimedia-Site-requests
Glaisher created T143855: tux doesn't let the user know about it if the language is a non-translatable language.
Aug 25 2016, 5:45 AM · Language-2018-Apr-June, MediaWiki-extensions-Translate

Aug 24 2016

Glaisher edited projects for T143806: Add feature to show units with no reviews by any user, added: MediaWiki-extensions-Translate; removed translatewiki.net.
Aug 24 2016, 5:24 PM · MediaWiki-extensions-Translate
Glaisher placed T25310: Global suppression does not work properly when the target has already been locally blocked up for grabs.
Aug 24 2016, 5:59 AM · MediaWiki-Platform-Team, Trust-and-Safety, Editing-team, User-Rxy, Vuln-Infoleak, MediaWiki-Revision-deletion, Stewards-and-global-tools, MediaWiki-extensions-CentralAuth
Glaisher added a comment to T25310: Global suppression does not work properly when the target has already been locally blocked.

I have written https://meta.wikimedia.org/wiki/User:Glaisher/globalSuppress.js as it's not easy to do this server-side without resolving the aforementioned issues. I have done some testing of it at beta cluster and it seems to work okay but do NOT use it yet because I'm not completely sure it would work properly in all cases. It would be nice if I could coordinate with a steward who is willing to help, preferably on IRC, so that we can make it ready for production use.

Aug 24 2016, 5:58 AM · MediaWiki-Platform-Team, Trust-and-Safety, Editing-team, User-Rxy, Vuln-Infoleak, MediaWiki-Revision-deletion, Stewards-and-global-tools, MediaWiki-extensions-CentralAuth

Aug 23 2016

Glaisher added a member for MediaWiki-extensions-Translate: Glaisher.
Aug 23 2016, 4:00 PM
Glaisher edited projects for T143564: MediaWiki:Helppage no longer works, added: Wikimedia-Site-requests; removed MediaWiki-General.

OK, I see it when I change my UI language to Italian. The code is working as expected. I am changing this to a site request.

Aug 23 2016, 12:46 PM · Patch-For-Review, Wikimedia-Site-requests, Commons
Glaisher added a comment to T143564: MediaWiki:Helppage no longer works.

"Help center" link on the sidebar links to https://commons.wikimedia.org/wiki/Special:MyLanguage/Help:Contents for me.

Aug 23 2016, 10:15 AM · Patch-For-Review, Wikimedia-Site-requests, Commons
Glaisher closed T125221: globalblock API modifies existing blocks without confirmation from the user as Resolved.
Aug 23 2016, 8:12 AM · MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), Patch-For-Review, GlobalBlocking

Aug 22 2016

Glaisher added a comment to T143531: Back out the change that changed action=purge to require a confirmation page.

I think that's a statement about philosophy. Before the current change, action=purge as a GET would purge, and action=purge as a POST would purge. Now there's no such thing as action=purge as a GET, because the confirmation page turns it into a POST.

So this is a change to make implementation match philosophy. Okay, and there's no going back from that.

Aug 22 2016, 3:58 PM · MediaWiki-General, Regression
Glaisher added a comment to T143531: Back out the change that changed action=purge to require a confirmation page.

It's not a matter of the easiness or difficulty of the request. GET/POST distinction is going to be used for checking whether the request is a read-only and if so to route the request accordingly in a multi-datacenter setup. Your expectation about GET/POST is also wrong as GET is actually supposed to be retrieving data only not for modifying; it wasn't respected previously.

Aug 22 2016, 10:29 AM · MediaWiki-General, Regression
Glaisher added a comment to T124013: Do not allow saving translations to blacklisted language codes.

CentralNotice currently depends on the user being able to save to the CNBanner namespace's /en pages so doing this would partially break it at Meta because 'en' is blacklisted for all groups on Wikimedia. That blacklist entry shouldn't actually be needed and manual source page edits should actually be directly prevented on Translate but even then we would need to add exceptions for CNBanner.

Aug 22 2016, 6:29 AM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Translate
Glaisher added a comment to T143531: Back out the change that changed action=purge to require a confirmation page.

This wasn't done just for the sake of making it difficult for users. There are actual valid technical reasons as stated on T135170 so it won't be reverted just because of it.

Aug 22 2016, 3:45 AM · MediaWiki-General, Regression

Aug 21 2016

Glaisher moved T143396: Display translated page title in search results from To triage to Special:LinkSearch on the MediaWiki-Special-pages board.
Aug 21 2016, 12:42 PM · Patch-Needs-Improvement, Discovery-Search, MediaWiki-Search, Discovery-ARCHIVED, MediaWiki-extensions-Translate
Glaisher edited projects for T143396: Display translated page title in search results, added: MediaWiki-Special-pages; removed CirrusSearch.
Aug 21 2016, 12:41 PM · Patch-Needs-Improvement, Discovery-Search, MediaWiki-Search, Discovery-ARCHIVED, MediaWiki-extensions-Translate
Glaisher triaged T142292: Figure out ways to reduce number of edits where the translation unit contains exactly the source text as Low priority.

I had created https://meta.wikimedia.org/wiki/Special:AbuseFilter/125 and it seems to be working there. Since this requires another extension for working, I believe something needs to be implemented directly on the Translate extension before this task can be closed. But triaging as low since there is a mechanism to reduce these now.

Aug 21 2016, 12:40 PM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher moved T142840: tux does not prevent translations of source language when language is changed through language selector from Backlog to tux on the MediaWiki-extensions-Translate board.
Aug 21 2016, 12:37 PM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Translate
Glaisher moved T143007: $wgTranslatePageTranslationULS don't changes the corresponding translation page from Backlog to page translation on the MediaWiki-extensions-Translate board.
Aug 21 2016, 12:36 PM · MediaWiki-extensions-Translate
Glaisher moved T143326: Invent automatic segmentation in translation units without <translate> tags from Backlog to page translation on the MediaWiki-extensions-Translate board.
Aug 21 2016, 12:36 PM · Epic, MediaWiki-Page-editing, MediaWiki-extensions-Translate
Glaisher moved T143327: Make the Translate extension be based on DOM, not strings from Backlog to page translation on the MediaWiki-extensions-Translate board.
Aug 21 2016, 12:36 PM · Epic, MediaWiki-Page-editing, MediaWiki-extensions-Translate

Aug 20 2016

Glaisher reopened T143073: Fatal error: Argument 1 passed to MessageHandle::__construct() must be an instance of Title, null given as "Open".

Uh.. how did that happen??

Aug 20 2016, 5:32 PM · Patch-For-Review, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), Language-Q1-2016-17 Sprint 4, MediaWiki Language Extension Bundle, Language-Engineering July-September 2016, MediaWiki-extensions-Translate, Wikimedia-production-error
Glaisher closed T143073: Fatal error: Argument 1 passed to MessageHandle::__construct() must be an instance of Title, null given as Resolved by committing rETRA8e1992b2e720: Guard against null $title in TranslateHooks::onAbuseFilterFilterAction.
Aug 20 2016, 5:29 PM · Patch-For-Review, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), Language-Q1-2016-17 Sprint 4, MediaWiki Language Extension Bundle, Language-Engineering July-September 2016, MediaWiki-extensions-Translate, Wikimedia-production-error

Aug 16 2016

Glaisher added a comment to T143073: Fatal error: Argument 1 passed to MessageHandle::__construct() must be an instance of Title, null given.

git diff origin/wmf/1.28.0-wmf.3..origin/wmf/1.28.0-wmf.4 reveals no likely suspects. Timing might just be a coincidence.

Aug 16 2016, 6:08 AM · Patch-For-Review, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), Language-Q1-2016-17 Sprint 4, MediaWiki Language Extension Bundle, Language-Engineering July-September 2016, MediaWiki-extensions-Translate, Wikimedia-production-error

Aug 14 2016

Glaisher moved T142923: Missing move log and merge log of the target page in dewiki from To triage to Special:MergeHistory on the MediaWiki-Special-pages board.
Aug 14 2016, 6:13 AM · MediaWiki-Special-pages, MediaWiki-Logevents
Glaisher edited projects for T142923: Missing move log and merge log of the target page in dewiki, added: MediaWiki-Special-pages; removed SRE.
Aug 14 2016, 6:12 AM · MediaWiki-Special-pages, MediaWiki-Logevents

Aug 13 2016

Glaisher added a project to T138919: Create intro/summary for Special:GlobalRenameUser: good first task.

Okay, I guess you meant <fieldset> not <input>. This would need to be patched directly on this page then because FormSpecialPage doesn't provide that by default.

Aug 13 2016, 3:57 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), MediaWiki-Platform-Team, Patch-For-Review, good first task, GlobalRename, MediaWiki-extensions-CentralAuth
Glaisher updated subscribers of T142231: The Optimistic Guy -> RainFall global rename completed without log entry.

If we already have known reports about this, it is likely that there are more unknown occurrences of this elsewhere too (due to lock waits, not just long queries). Having inconsistent states seem like a pretty severe issue to me. I have written a possible explanation at T141988#2519765. @aaron Is it possible for that to happen or is there another explanation? Seems like something that need to be fixed in the short term before major bugs arise from this.

Aug 13 2016, 3:51 PM · MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), Performance-Team, Patch-For-Review, Performance Issue, MediaWiki-libs-Rdbms, DBA, MediaWiki-extensions-CentralAuth, GlobalRename
Glaisher added a comment to T138919: Create intro/summary for Special:GlobalRenameUser.

The blue box schould be below the Rename global user. Currently it is directly in the <input> field.

Aug 13 2016, 3:43 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), MediaWiki-Platform-Team, Patch-For-Review, good first task, GlobalRename, MediaWiki-extensions-CentralAuth
Glaisher added a project to T140458: Add subtitle to main Special:GlobalRenameProgress page from subpages: Patch-For-Review.
Aug 13 2016, 3:42 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), Patch-For-Review, good first task, GlobalRename, MediaWiki-extensions-CentralAuth
Glaisher added a comment to T142757: Special:Log is missing actions of type "globalauth" from the "Maintenance script" user .

Why was the comment removed? Is it not valid? Perhaps you are correct because I closed this based on an assumption, not after confirming. :)

Aug 13 2016, 3:29 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Logevents
Glaisher merged T142757: Special:Log is missing actions of type "globalauth" from the "Maintenance script" user into T142755: Can't look for logs for Global rename script.
Aug 13 2016, 11:49 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-Logevents
Glaisher merged task T142757: Special:Log is missing actions of type "globalauth" from the "Maintenance script" user into T142755: Can't look for logs for Global rename script.
Aug 13 2016, 11:49 AM · MediaWiki-extensions-CentralAuth, MediaWiki-Logevents
Glaisher edited projects for T142757: Special:Log is missing actions of type "globalauth" from the "Maintenance script" user , added: MediaWiki-Special-pages; removed Stewards-and-global-tools, GlobalRename, MediaWiki-extensions-CentralAuth.

Not a CA-specific bug. Closing as duplicate of T142755: Can't look for logs for Global rename script

Aug 13 2016, 11:49 AM · MediaWiki-extensions-CentralAuth, MediaWiki-Logevents
Glaisher removed projects from T142755: Can't look for logs for Global rename script: Stewards-and-global-tools, GlobalRename, MediaWiki-extensions-CentralAuth.
Aug 13 2016, 11:43 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-Logevents

Aug 12 2016

Glaisher renamed T142840: tux does not prevent translations of source language when language is changed through language selector from Translate extension gets confused about Special:PageLanguage to tux does not prevent translations of source language when language is changed through language selector.
Aug 12 2016, 5:00 PM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Translate
Glaisher removed projects from T142840: tux does not prevent translations of source language when language is changed through language selector: I18n, MediaWiki-Internationalization.

Broken pages
An old version of this page is marked for translation, but the latest version cannot be marked for translation.
Test4 (remove from translation)

Probably because the job which updates it hasn't completed when Special:PageTranslation is rendered.

Aug 12 2016, 4:59 PM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Translate
Glaisher added a project to T142210: wgPageParseReport is empty on preview / section preview: User-notice.
Aug 12 2016, 11:59 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), Performance-Team, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MediaWiki-Parser, Regression
Glaisher added a comment to T141530: Gadgets and Preferences not loading in Wiktionary from Time to Time.

That URL is not correct. You should instead use https://en.wiktionary.org/wiki/natatorium?debug=1 (note the ? instead of &).
That module 'ext.uls.compactlinks' is from the ULS extension so a maintainer of that extension should probably look into it.

Aug 12 2016, 11:17 AM · Local-Wiki-Template-And-Gadget-Issues, WMF-General-or-Unknown

Aug 11 2016

Glaisher added a project to T142679: Email not received after talk page message left on Meta: Notifications.
Aug 11 2016, 5:49 AM · Notifications, Collaboration-Team-Triage
Glaisher added a comment to T91928: The Event Organiser's Userright.

I'll note that it is now possible to exempt specific IPs (and users logged-in from those IPs) from having to submit captcha by listing the IP addresses or IP ranges at MediaWiki:Captcha-ip-whitelist on the wiki. I realize that it doesn't meet the requirements of this task because only sysops (and others who are allowed to edit interface pages) can edit these pages but at least it is better than how it was previously and I encourage organizers to make use of it (by requesting sysops to add the IPs there) for a better experience for participants.

Aug 11 2016, 5:02 AM · MediaWiki-extensions-ThrottleOverride
Glaisher closed T126129: abusefilter-view-private should let you view histories of private filters as Resolved.
Aug 11 2016, 4:27 AM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), Patch-For-Review, Stewards-and-global-tools, AbuseFilter
Glaisher closed T142566: Global filter at metawiki still applying despite being disabled and de-globalled as Resolved.
Aug 11 2016, 4:27 AM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), AbuseFilter, Stewards-and-global-tools

Aug 10 2016

Glaisher added a project to T142576: Special:Wantedpages includes pages not actually linked when using #ifexists: MediaWiki-Special-pages.
Aug 10 2016, 5:29 PM · ParserFunctions
Glaisher added a comment to T142566: Global filter at metawiki still applying despite being disabled and de-globalled.

Global abuse filters are cached indefinitely and it is invalidated whenever a global abuse filter is modified. However, there is a bug in the logic which is checked for when to invalidate the cache; it is only invalidated if the filter does have "global" set. As a result, it's not reliable in cases such as these (https://meta.wikimedia.org/wiki/Special:AbuseFilter/history/89) so we should change it to be invalidated also if the "global" flag was set previously. In the meantime, a steward should probably check the global flag in the filter editor (and remove it again, if you want) to invalidate the cache.

Aug 10 2016, 4:58 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), AbuseFilter, Stewards-and-global-tools

Aug 9 2016

Glaisher added a comment to T142492: Can't add to autochecked group on mediawiki.org.

This was caused by https://gerrit.wikimedia.org/r/#/c/302987/

Aug 9 2016, 4:15 PM · Wikimedia-Site-requests
Glaisher closed T137715: Explicitly marking translation unit with !!FUZZY!! does not update corresponding translation page as Resolved.

After this edits done with a FUZZY would mean the page would be updated with the source text.

Aug 9 2016, 8:29 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review, MediaWiki-extensions-Translate
Glaisher claimed T114592: A translatable subpage page should not be messed while moving subpages.
Aug 9 2016, 5:34 AM · User-notice-archive, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Language-Team (Language-2018-October-December), MediaWiki-General, MediaWiki-extensions-Translate
Glaisher merged task T126376: Translations of subpages aren't moved when a translatable page is moved into T114592: A translatable subpage page should not be messed while moving subpages.
Aug 9 2016, 5:12 AM · MediaWiki-extensions-Translate
Glaisher merged T126376: Translations of subpages aren't moved when a translatable page is moved into T114592: A translatable subpage page should not be messed while moving subpages.
Aug 9 2016, 5:12 AM · User-notice-archive, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Language-Team (Language-2018-October-December), MediaWiki-General, MediaWiki-extensions-Translate
Glaisher added a comment to T126376: Translations of subpages aren't moved when a translatable page is moved.

I was able to reproduce the second issue and it has already been reported as T114592: A translatable subpage page should not be messed while moving subpages so I will close this task as it reports two already reported separate issues.

Aug 9 2016, 5:11 AM · MediaWiki-extensions-Translate
Glaisher raised the priority of T114592: A translatable subpage page should not be messed while moving subpages from Medium to High.

I was able to confirm this while testing another move-related patch today. This is actually quite a severe bug, imo, and would cause large scale disruption and lots of work for users if done on translatable pages with lots of translations so increasing priority.

Aug 9 2016, 5:09 AM · User-notice-archive, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Language-Team (Language-2018-October-December), MediaWiki-General, MediaWiki-extensions-Translate
Glaisher closed T61715: Saving a translation that hits the URL blacklist is marked as saved as Resolved.
Aug 9 2016, 3:11 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher closed T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved as Resolved.
Aug 9 2016, 3:10 AM · MediaWiki-extensions-Translate

Aug 8 2016

Glaisher updated the task description for T114101: [TUX] Improve insertables insertion to replace selected text.
Aug 8 2016, 5:35 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Language-Team (Language-2022-July-September), MediaWiki-extensions-Translate
Glaisher updated subscribers of T114101: [TUX] Improve insertables insertion to replace selected text.
Aug 8 2016, 5:35 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Language-Team (Language-2022-July-September), MediaWiki-extensions-Translate
Glaisher created T142411: Improve how errors are displayed in tux.
Aug 8 2016, 5:18 PM · MediaWiki-extensions-Translate
Glaisher closed T49072: [TUX] Split export functionality off of Special:Translate as Resolved.
Aug 8 2016, 3:44 PM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review, Technical-Debt, MediaWiki-extensions-Translate
Glaisher closed T49072: [TUX] Split export functionality off of Special:Translate, a subtask of T136854: Refactor SpecialTranslate code to make it more readable and improve its design, as Resolved.
Aug 8 2016, 3:44 PM · Technical-Debt, MediaWiki-extensions-Translate
Glaisher added a project to T142329: Can't access large watchlist on nlwiki: 503 error: WMF-General-or-Unknown.
Aug 8 2016, 5:26 AM · Growth-Team-Filtering, Growth-Team, WMF-General-or-Unknown, MediaWiki-Watchlist

Aug 7 2016

Glaisher added a comment to T141530: Gadgets and Preferences not loading in Wiktionary from Time to Time.

Okay, these search results show that there are several gadgets which call $.cookie without registering it as a dependency in MediaWiki:Gadgets-definition. Please ask an administrator to add it as a dependency for those gadgets.

Aug 7 2016, 5:28 PM · Local-Wiki-Template-And-Gadget-Issues, WMF-General-or-Unknown
Glaisher added a comment to T141530: Gadgets and Preferences not loading in Wiktionary from Time to Time.

I don't see a reference to $.cookie in https://github.com/wikimedia/mediawiki-extensions-Cite/blob/master/modules/ext.cite.a11y.js Can you try checking whether that error appears again after clearing your browser cache and also please provide the errors shown in the console in debug mode. You can switch to debug mode by adding debug=1 to the URL (similar to action=purge).

Aug 7 2016, 5:19 PM · Local-Wiki-Template-And-Gadget-Issues, WMF-General-or-Unknown
Glaisher added a comment to T69745: Translate extension shows no "edit conflict" error when two users translate the same thing.

I guess you meant https://meta.wikimedia.org/w/index.php?title=CNBanner:FR2014_translations-legal-us/pt&diff=9145183&oldid=9145115 not https://meta.wikimedia.org/w/index.php?title=CNBanner:FR2014_translations-legal-us/pt&oldid=8920101 ]]There are several days in between those edits in the description..

Aug 7 2016, 4:33 PM · MediaWiki-extensions-Translate
Glaisher claimed T61715: Saving a translation that hits the URL blacklist is marked as saved.

https://gerrit.wikimedia.org/r/#/c/303430/

Aug 7 2016, 3:49 PM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher updated the task description for T36182: Special:Translate unable to save where CAPTCHA is required.
Aug 7 2016, 3:49 PM · MediaWiki-extensions-Translate
Glaisher claimed T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved.
Aug 7 2016, 3:39 PM · MediaWiki-extensions-Translate
Glaisher added a comment to T116425: Rename user creates lag on enwiki.

It's happening again now on s7.

Aug 7 2016, 10:23 AM · Patch-For-Review, Wikimedia-Incident, MediaWiki-User-rename, DBA, Performance Issue
Glaisher added a comment to T116425: Rename user creates lag on enwiki.

There was slave lag on Meta-Wiki (s7) causing writes to be locked for more than three minutes a little while ago. I suspect (but not completely sure) that it was also related to a global rename that was done at about the same time. https://meta.wikimedia.org/wiki/Special:CentralAuth/Derakhshan contains 7000+ edits on fawiki which is also s7. Probably worth more investigation.

Aug 7 2016, 10:22 AM · Patch-For-Review, Wikimedia-Incident, MediaWiki-User-rename, DBA, Performance Issue
Glaisher moved T142331: Errors shown in tux are not cleared after a successful save from Backlog to tux on the MediaWiki-extensions-Translate board.
Aug 7 2016, 10:16 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher created T142331: Errors shown in tux are not cleared after a successful save.
Aug 7 2016, 10:15 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher added a comment to T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved.

During testing, I also noticed that it doesn't error for SpamBlacklist hits either.

Aug 7 2016, 5:13 AM · MediaWiki-extensions-Translate

Aug 6 2016

Glaisher moved T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved from Backlog to tux on the MediaWiki-extensions-Translate board.
Aug 6 2016, 9:34 AM · MediaWiki-extensions-Translate
Glaisher moved T142293: Allow to easily protect translatable and translation pages completely from Backlog to page translation on the MediaWiki-extensions-Translate board.
Aug 6 2016, 9:34 AM · MediaWiki-extensions-Translate
Glaisher created T142293: Allow to easily protect translatable and translation pages completely.
Aug 6 2016, 9:33 AM · MediaWiki-extensions-Translate
Glaisher created T142292: Figure out ways to reduce number of edits where the translation unit contains exactly the source text.
Aug 6 2016, 9:27 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MediaWiki-extensions-Translate
Glaisher removed a project from T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved: AbuseFilter.
Aug 6 2016, 9:23 AM · MediaWiki-extensions-Translate
Glaisher created T142291: Edits prevented by AbuseFilter through tux interface is shown as successfully saved.
Aug 6 2016, 9:19 AM · MediaWiki-extensions-Translate

Aug 4 2016

Glaisher closed T62393: source language as Language to notify error should be handled more gracefully as Resolved.
Aug 4 2016, 8:42 AM · MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), TranslationNotifications

Aug 3 2016

Glaisher merged task T141993: Offer a "languages to exclude" or something similar on Special:NotifyTranslators into T63125: Ability to notify all languages except some.
Aug 3 2016, 5:29 PM · TranslationNotifications
Glaisher merged T141993: Offer a "languages to exclude" or something similar on Special:NotifyTranslators into T63125: Ability to notify all languages except some.
Aug 3 2016, 5:29 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), Language-Team (Language-2023-January-March), TranslationNotifications
Glaisher added a member for TranslationNotifications: Glaisher.
Aug 3 2016, 5:28 PM
Glaisher added a watcher for TranslationNotifications: Glaisher.
Aug 3 2016, 5:27 PM
Glaisher added a comment to T141988: After operation aborted, on-wiki log is missing, but it was reported to irc.wikimedia.

OK, after looking at the code, I think this is what happened. MediaWiki starts the transaction with the first query. After that, the queries from User::saveSettings are issued but as it is not committed at this point, it doesn't block further code from being executed. Then the job queue insert code is executed where the jobs are sent to the Redis queue. After this, the log entry insert query is also issue and it is also sent to the IRC feed. But these queries are actually committed during preOutputCommit() where MediaWiki detects that the transaction is taking longer than the set time and so throws an exception aborting the DB transaction. However, since the jobs has already been sent to Redis and the RC entry sent to the IRC feed, they work okay as if the DB transaction wasn't aborted. I don't know for sure whether this is what actually happened since I am not very familiar with what happens during the lifetime of an MW request and also have made some assumptions about how they get executed but this seems likely.
So for atomicity, the expected behavior would be: 1) jobs should be removed from the queue if an exception was thrown after they have been sent or not sent at all if we know that something went wrong 2) the RC entry shouldn't also be sent to the IRC feed before everything is completed fine. And fix T63122: Timeout when sending translation notification (yet again) of course.

Aug 3 2016, 5:18 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes, Patch-For-Review, TranslationNotifications, Performance Issue, MediaWiki-libs-Rdbms, DBA
Glaisher added a comment to T141988: After operation aborted, on-wiki log is missing, but it was reported to irc.wikimedia.

Note: The actual issue for the long duration of the submission request is tracked at T63122.

Aug 3 2016, 4:44 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes, Patch-For-Review, TranslationNotifications, Performance Issue, MediaWiki-libs-Rdbms, DBA
Glaisher added a comment to T141988: After operation aborted, on-wiki log is missing, but it was reported to irc.wikimedia.

The actual delivery is postponed to job queue, so I find it unlikely to be the issue here.

Aug 3 2016, 4:40 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes, Patch-For-Review, TranslationNotifications, Performance Issue, MediaWiki-libs-Rdbms, DBA
Glaisher merged T142005: No log entry was inserted for translation notification into T141988: After operation aborted, on-wiki log is missing, but it was reported to irc.wikimedia.
Aug 3 2016, 4:36 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes, Patch-For-Review, TranslationNotifications, Performance Issue, MediaWiki-libs-Rdbms, DBA
Glaisher merged task T142005: No log entry was inserted for translation notification into T141988: After operation aborted, on-wiki log is missing, but it was reported to irc.wikimedia.
Aug 3 2016, 4:36 PM · TranslationNotifications
Glaisher created T142005: No log entry was inserted for translation notification.
Aug 3 2016, 4:34 PM · TranslationNotifications