Change Details

According to a [[ https://phabricator.wikimedia.org/T257582#6543900 | conversation on T257582 ]], one of the Jenkins pipeline jobs that is always run on skins and extensions `mwgate-node10-docker` expects `npm test` to be responsible for linting and nothing else. It was suggested by @hashar to create a secondary script that would run the linters and the build. For example: ``` { "scripts": { "test": "npm -s run lint", "build": "webpack -p && bin/diff-bundle && tsc && npm -s run doc, "validate": "npm run test && npm run build" } } ``` This task is just for shuffling around the npm scripts to adhere to CI expectations, and I believe this would be on the feat/search branch as that has a different package.json setup than master.

According to a [[ https://phabricator.wikimedia.org/T257582#6543900 | conversation on T257582 ]], one of the Jenkins pipeline jobs that is always run on skins and extensions `mwgate-node10-docker` expects `npm test` to be responsible for linting and nothing else. It was suggested by @hashar to create a secondary script that would run the linters and the build. For example: ``` { "scripts": { "test": "npm -s run lint", "build": "webpack -p && bin/diff-bundle && tsc", "validate": "npm run test && npm run build && npm run doc", "doc" : "npm -s run doc" } } ``` This task is just for shuffling around the npm scripts to adhere to CI expectations, and I believe this would be on the feat/search branch as that has a different package.json setup than master.

According to a [[ https://phabricator.wikimedia.org/T257582#6543900 | conversation on T257582 ]], one of the Jenkins pipeline jobs that is always run on skins and extensions `mwgate-node10-docker` expects `npm test` to be responsible for linting and nothing else. It was suggested by @hashar to create a secondary script that would run the linters and the build. For example: ``` { "scripts": { "test": "npm -s run lint", "build": "webpack -p && bin/diff-bundle && tsc && npm -s run doctsc", "validate": "npm run test && npm run build && npm run doc", "doc" : "npm -s run doc" } } ``` This task is just for shuffling around the npm scripts to adhere to CI expectations, and I believe this would be on the feat/search branch as that has a different package.json setup than master.