AbuseFilter is incompatible with PostgreSQL database
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lahwaacz
	Jan 19 2018, 5:17 PM

Description

Running the maintenance/update.php script on a PostgreSQL database when the AbuseFilter extension is loaded results in this error:

[94d17a1cd1c1881e7480c9ae] [no req]   ArgumentCountError from line 699 of /srv/http/mywiki/includes/installer/PostgresUpdater.php: Too few arguments to function PostgresUpdater::changeField(), 3 passed in /srv/http/mywiki/includes/installer/DatabaseUpdater.php on line 472 and exactly 4 expected
Backtrace:
#0 /srv/http/mywiki/includes/installer/DatabaseUpdater.php(472): PostgresUpdater->changeField(string, string, string)
#1 /srv/http/mywiki/includes/installer/DatabaseUpdater.php(440): DatabaseUpdater->runUpdates(array, boolean)
#2 /srv/http/mywiki/maintenance/update.php(174): DatabaseUpdater->doUpdates(array)
#3 /srv/http/mywiki/maintenance/doMaintenance.php(111): UpdateMediaWiki->execute()
#4 /srv/http/mywiki/maintenance/update.php(219): require_once(string)
#5 {main}

Hence, the AbuseFilter extension cannot be used on systems using PostgreSQL.

Details

	Subject	Repo	Branch	Lines +/-
	Set default when changing afl_namespace on pg	mediawiki/extensions/AbuseFilter	master	+1 -1

Customize query in gerrit

Event Timeline

Lahwaacz created this task.Jan 19 2018, 5:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2018, 5:17 PM

Which AbuseFilter version and which PostgreSQL is this about?

It's MediaWiki 1.30.0, AbuseFilter REL1_30 and PostgreSQL 10.1.

https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blame/master/includes/AbuseFilter.hooks.php#L604-L605

Looks to have been like that a while.

Needs to pass a default to that function...

https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/abusefilter.tables.pg.sql#L49 but no default is defined there

https://gerrit.wikimedia.org/r/#/c/405360/

matej_suchanek added a project: Patch-For-Review.Jan 24 2018, 5:46 PM

Change 405360 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Set default when changing afl_namespace on pg

https://gerrit.wikimedia.org/r/405360

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 2 2018, 8:00 PM

matej_suchanek closed this task as Resolved.Feb 10 2018, 9:42 AM

matej_suchanek assigned this task to Reedy.

matej_suchanek removed a project: Patch-For-Review.

matej_suchanek moved this task from Backlog to Internal bugs on the AbuseFilter board.

AbuseFilter is incompatible with PostgreSQL databaseClosed, ResolvedPublicActions

Description

Details

Event Timeline

AbuseFilter is incompatible with PostgreSQL database
Closed, ResolvedPublic
Actions