Page MenuHomePhabricator
Create Task
Maniphest T248557

Indicators for problematic changes (r) are missing from RC
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To
None
Authored By
matej_suchanek
Mar 26 2020, 8:59 AM
Tags
Referenced Files
F34112251: obrazek.png
Feb 18 2021, 12:50 PM
F34112249: obrazek.png
Feb 18 2021, 12:50 PM
F34112247: obrazek.png
Feb 18 2021, 12:50 PM
F31703028: obrazek.png
Mar 26 2020, 9:10 AM
F31702997: obrazek.png
Mar 26 2020, 8:59 AM
F31702999: obrazek.png
Mar 26 2020, 8:59 AM
Subscribers
Aklapper
Catrope
Etonkovidova
matej_suchanek

Description

Steps to Reproduce:

  1. Visit recent changes of a wiki which has ORES edit predictions enabled (eg. cswiki, Wikidata).
  2. Use only the filters "Very likely has problems" & "Page edits" (link). Notice there is a legend which explains the meaning of r.
  3. Try both grouped and ungrouped mode, old interface or watchlist.

Actual Results:

  • None of these changes has r indicator, although they are identified as potentially problematic. Highlighting does work.
  • Surprisingly, the indicators can be seen in Special:Contributions.

Expected Results:

  • Changes identified as potentially problematic have r indicator in the recent changes (watchlist).
ungrouped recent changes (cswiki)grouped recent changes (cswiki)contributions
obrazek.png (88×1 px, 13 KB)
obrazek.png (96×1 px, 14 KB)
obrazek.png (138×1 px, 10 KB)

Details

SubjectRepoBranchLines +/-
Show "r" flag regardless of UI if enabledmediawiki/extensions/ORESmaster+5 -8
Update delimiter for problematic flag insertionmediawiki/extensions/ORESmaster+5 -5
Customize query in gerrit

Event Timeline

matej_suchanek created this task.Mar 26 2020, 8:59 AM
Restricted Application added projects: Growth-Team, Machine-Learning-Team. · View Herald TranscriptMar 26 2020, 8:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matej_suchanek added a project: Regression.Mar 26 2020, 9:08 AM
matej_suchanek updated the task description. (Show Details)
Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Apr 2 2020, 9:52 PM
Etonkovidova subscribed.

Thanks @matej_suchanek
Confirmed - r is not present on Recent changes/Watchlist desplite the legend stating that it should be there. Special:Contirbutions will display r - just as the bug report says.

Special:Preferences#mw-prefsection-rc and Special:Preferences#mw-prefsection-watchlist also display the option "Highlight likely problem edits with colors and an "r" for "needs review"" which also does not add r.

I also checked if users with specific rights - e.g. Reviewers - might see it and it's not the case.

On enwiki the legend has a link to ORES review tool which has an outdated information about r usage and the screenshots that display the usage of r that is not in place anymore.
Moved to "Needs Discussion/Analysis" on Growth team Workboard.

Etonkovidova added a subscriber: Catrope.Apr 3 2020, 5:10 PM
Halfak moved this task from Unsorted to Backlog/Lift Wing on the Machine-Learning-Team board.Apr 6 2020, 4:56 PM
Catrope added a comment.Apr 7 2020, 6:24 PM

This happens because the ORES extension looks for <span class="mw-changeslist-separator">. .</span> when trying to insert the r (see this code). But the HTML for this changed a number of months ago (these spans are now empty and the dots are injected using CSS), which broke this code.

gerritbot added a comment.Sep 9 2020, 5:50 PM

Change 626193 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/ORES@master] Update delimiter for problematic flag insertion

https://gerrit.wikimedia.org/r/626193

gerritbot added a project: Patch-For-Review.Sep 9 2020, 5:50 PM
matej_suchanek claimed this task.Sep 9 2020, 5:50 PM
Maintenance_bot moved this task from Backlog/Lift Wing to Backlog/ORES on the Machine-Learning-Team board.Jan 19 2021, 11:29 PM
gerritbot added a comment.Jan 25 2021, 8:39 AM

Change 626193 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Update delimiter for problematic flag insertion

https://gerrit.wikimedia.org/r/626193

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2021, 9:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 25 2021, 10:00 AM
matej_suchanek added a comment.EditedJan 31 2021, 2:46 PM

Still does not work in either backend (old and grouped)...

matej_suchanek removed matej_suchanek as the assignee of this task.Feb 18 2021, 12:50 PM
matej_suchanek updated the task description. (Show Details)
matej_suchanek added a comment.Feb 18 2021, 1:18 PM

Moreover, ChangesListHooksHandler::onOldChangesListRecentChangesLine is supposed to add some CSS classes (damaging, ores-highlight), but they cannot be found in the recent changes list as well. So I suspect from the code that the problem is in ChangesListHooksHandler::getScoreRecentChangesList (used in ChangesListHooksHandler but not in ContributionsHooksHandler).

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
gerritbot added a comment.Mar 29 2024, 9:45 AM

Change #1015516 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/ORES@master] Show "r" flag regardless of UI if enabled

https://gerrit.wikimedia.org/r/1015516

gerritbot added a project: Patch-For-Review.Mar 29 2024, 9:45 AM
matej_suchanek removed a project: MediaWiki-Recent-changes.Mar 29 2024, 9:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL