Page MenuHomePhabricator
Create Task
Maniphest T249204

New video player does not leave enough space in gallery
Closed, ResolvedPublic
Actions

Description

In this section, I added a video: https://de.wikipedia.org/wiki/Hubtor#Beispiele

If I'm not activating the new videoplayer, it looks like this:

grafik.png (478×752 px, 426 KB)

If I'm activating it, it looks like this:

grafik.png (447×670 px, 386 KB)

As you can see in the second screenshot there is no space between the video, and the foto on the right. This should not happen.

Related Objects

Event Timeline

Luke081515 created this task.Apr 2 2020, 10:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 10:07 AM
Luke081515 added projects: Video, Multimedia.Apr 2 2020, 10:08 AM
Aklapper removed a project: Multimedia.Apr 2 2020, 12:06 PM
• brooke subscribed.Apr 2 2020, 6:02 PM

Can't reproduce in Chrome, but can in Firefox. Something seems wonky with the gallery layout in Firefox specifically.

• brooke added a comment.Apr 2 2020, 6:11 PM

Looks like there's two things going on:

  1. the video preview doesn't resize to fit the gallery container (it's an actual <video> with a poster image under the lid, not an <img>, so styles might not be applying to it that need to be); this usually adds extra space around the image
  2. in Firefox, the video sometimes overflows the available space, causing insufficient space around the image as in the screenshot

Fixing 1) should fix 2) as a side effect, I think.

• brooke renamed this task from New video player does not leave enough space to New video player does not leave enough space in gallery.Apr 2 2020, 6:14 PM
• brooke moved this task from Backlog to Bugs on the VideoJS player board.
Iniquity mentioned this in T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.Aug 3 2020, 5:21 PM
Iniquity subscribed.Jan 8 2022, 3:27 AM

Cant reproduse it in new Firefox. Is the problem still there?

TheDJ closed this task as Resolved.Jan 9 2022, 9:03 PM
TheDJ claimed this task.
TheDJ subscribed.

This was fixed when we switched from full inline players back to img+playbutton opening a media player dialog.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL