Page MenuHomePhabricator
Create Task
Maniphest T336449

Convert PayPal EC adapter to use SmashPig for API calls
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

We have implemented the necessary API calls in SmashPig so that we could retire the legacy orphan rectifier and get DonationInterface out of CRM (See T317245). Now we should use those same API calls under DonationInterface so we can clean up all the old do_transaction cruft.

Probably can break it up into two patches like with Ingenico - one patch to convert the initial donation setup API call and one patch to convert the status lookup and the capture calls.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.May 10 2023, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2023, 10:26 PM
AKanji-WMF moved this task from Triage to Next on the Fundraising-Backlog board.May 16 2023, 7:58 PM
AKanji-WMF moved this task from Next to Sprint +1 on the Fundraising-Backlog board.May 24 2023, 5:40 PM
Dwisehaupt set the point value for this task to 4.Jul 20 2023, 4:26 PM
AKanji-WMF moved this task from Sprint +1 to Next on the Fundraising-Backlog board.Aug 1 2023, 2:23 PM
AKanji-WMF moved this task from Next to Sprint +1 on the Fundraising-Backlog board.Aug 1 2023, 8:15 PM
AKanji-WMF moved this task from Sprint +1 to Next on the Fundraising-Backlog board.Aug 29 2023, 6:52 PM
AKanji-WMF moved this task from Next to Sprint +1 on the Fundraising-Backlog board.Sep 12 2023, 8:13 PM
AKanji-WMF moved this task from Sprint +1 to Near Future on the Fundraising-Backlog board.Oct 24 2023, 8:13 PM
AKanji-WMF added a project: fundraising near future temp.Feb 6 2024, 7:20 PM
AKanji-WMF removed a project: fundraising near future temp.Feb 6 2024, 8:13 PM
gerritbot added a comment.Feb 16 2024, 9:52 PM

Change 1004252 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP Use SmashPig to make initial PayPal EC setup calls

https://gerrit.wikimedia.org/r/1004252

gerritbot added a project: Patch-For-Review.Feb 16 2024, 9:52 PM
gerritbot added a comment.Feb 16 2024, 10:27 PM

Change 1004260 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Use standard 'language' and 'recurring' params

https://gerrit.wikimedia.org/r/1004260

gerritbot added a comment.Feb 20 2024, 3:46 PM

Change 1004260 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Use standard 'language' and 'recurring' params

https://gerrit.wikimedia.org/r/1004260

gerritbot added a comment.Mar 4 2024, 7:05 PM

Change 1008525 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add Address object for DonorDetails

https://gerrit.wikimedia.org/r/1008525

gerritbot added a comment.Mar 5 2024, 3:05 AM

Change 1008584 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP use SmashPig to get PayPal details

https://gerrit.wikimedia.org/r/1008584

gerritbot added a comment.Mar 5 2024, 2:25 PM

Change 1008869 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add address info to normalized PayPal responses

https://gerrit.wikimedia.org/r/1008869

gerritbot added a comment.Mar 8 2024, 2:32 PM

Change 1008525 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add Address object for DonorDetails

https://gerrit.wikimedia.org/r/1008525

gerritbot added a comment.Mar 18 2024, 12:35 PM

Change 1008869 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add address info to normalized PayPal responses

https://gerrit.wikimedia.org/r/1008869

AKanji-WMF moved this task from Near Future to Current Sprint on the Fundraising-Backlog board.Mar 27 2024, 7:15 PM
Ejegg added a project: Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun).Apr 1 2024, 3:33 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun) board.
Ejegg claimed this task.Apr 1 2024, 10:47 PM
gerritbot added a comment.Apr 2 2024, 3:47 PM

Change #1016388 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP use SmashPig for PayPal approvePayment

https://gerrit.wikimedia.org/r/1016388

gerritbot added a comment.Apr 3 2024, 1:06 PM

Change #1016787 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add getter for PayPal profileId

https://gerrit.wikimedia.org/r/1016787

gerritbot added a comment.Apr 3 2024, 6:22 PM

Change #1016828 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Use SmashPig to create recurring profile

https://gerrit.wikimedia.org/r/1016828

gerritbot added a comment.Apr 3 2024, 6:46 PM

Change #1016830 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Delete PayPal refund & cancel scripts and API calls

https://gerrit.wikimedia.org/r/1016830

gerritbot added a comment.Apr 3 2024, 6:46 PM

Change #1016831 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Delete a lot of now-unused PayPal adapter stuff

https://gerrit.wikimedia.org/r/1016831

gerritbot added a comment.Apr 3 2024, 7:08 PM

Change #1016837 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add normalized errors to PayPal create profile

https://gerrit.wikimedia.org/r/1016837

jgleeson moved this task from Doing to Being Reviewed on the Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun) board.Apr 4 2024, 2:31 PM
gerritbot added a comment.Apr 4 2024, 3:43 PM

Change #1016787 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add getter for PayPal profileId

https://gerrit.wikimedia.org/r/1016787

gerritbot added a comment.Apr 4 2024, 3:53 PM

Change #1016837 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add normalized errors to PayPal create profile

https://gerrit.wikimedia.org/r/1016837

gerritbot added a comment.Apr 4 2024, 9:41 PM

Change #1004252 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Use SmashPig to make initial PayPal EC setup calls

https://gerrit.wikimedia.org/r/1004252

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 4 2024, 10:00 PM
gerritbot added a comment.Apr 8 2024, 1:46 PM

Change #1008584 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Use SmashPig to get PayPal donor details

https://gerrit.wikimedia.org/r/1008584

gerritbot added a comment.Apr 8 2024, 3:02 PM

Change #1016388 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Use SmashPig for PayPal approvePayment

https://gerrit.wikimedia.org/r/1016388

AKanji-WMF edited projects, added Fundraising Sprint: gone(); removed Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun).Apr 9 2024, 8:10 PM
gerritbot added a comment.Apr 9 2024, 10:00 PM

Change #1016828 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Use SmashPig to create recurring profile

https://gerrit.wikimedia.org/r/1016828

gerritbot added a comment.Apr 9 2024, 10:00 PM

Change #1016830 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Delete PayPal refund & cancel scripts and API calls

https://gerrit.wikimedia.org/r/1016830

gerritbot added a comment.Apr 9 2024, 10:00 PM

Change #1016831 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Delete a lot of now-unused PayPal adapter stuff

https://gerrit.wikimedia.org/r/1016831

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 9 2024, 11:00 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint: gone() board.Apr 12 2024, 4:13 PM
AKanji-WMF edited projects, added Fundraising Sprint: hammertime($touch_this=false); removed Fundraising Sprint: gone().Tue, Apr 23, 8:59 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint: hammertime($touch_this=false) board.Wed, Apr 24, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:21 PM
XenoRyet closed this task as Resolved.Mon, May 6, 7:13 PM
XenoRyet set Final Story Points to 8.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL