Task Breakdown Notes

• To make sure we understand correctly, we won't update table's breakpoint, because it will be updated in a different task T348271, is it correct @Sarai-WMDE ?
• We need some clarification regarding which tokens are part of the scope of this task. For example; it is not completely clear if Dimensions/Spacing section is part of this task or T348732. May we please have a clear division between the tasks? @Sarai-WMDE

• To make sure we understand correctly, we won't update table's breakpoint, because it will be updated in a different task T348271, is it correct @Sarai-WMDE ?

Correct

• We need some clarification regarding which tokens are part of the scope of this task. For example; it is not completely clear if Dimensions/Spacing section is part of this task or T348732. May we please have a clear division between the tasks? @Sarai-WMDE

My bad, I thought the division was clear:

• Dimension and spacing tokens should be replaced by the new reusable variables as part of T350189: [WtC-M2] Create reusable custom variables for layout and spacing (I'm aware you'd like to discuss the scope of that task)
• Colors and typographic styles will be replaced as part of T348732: [WtC-M2] Use Codex tokens to style MSMF's interface colors and typography
• The current task involves replacing only the breakpoint tokens, but also applying certain changes to adjust the MSMF layout to the new grid system defined by Codex (the needed changes are listed under "Solution" and specified in the linked Figma specs)

Sprint Planning: review status. if still stalled, move back to stalled

https://github.com/wmde/wikidata-mismatch-finder/pull/849

This looks great! I only found a couple of small things to fix:

1. Footer padding: The horizontal padding of the Footer is not matching the specs/ aligned with the page margins (it remains 24px above the 1120px breakpoint, it becomes 16px below 720px instead of 640px)
2. Heading wrapping: Even if a gap has been implemented between the headings and their adjacent buttons, the buttons still don't take the space that is made available for then when the titles wrap (they display ellipsis even if there's enough room for them). I believe there's an easy fix for this: we just need to target these buttons and apply`flex-shrink: 0;` to them (see clarifying screenshots below).

Current state in staging	With flex-shrink 0
There's enough space for the button, but it still displays ellipsis.	The button takes the available space

https://github.com/wmde/wikidata-mismatch-finder/pull/874

Thanks for the fixes! :) All done now