Regression: Duplicate diff navigation links on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nintendofan885
	Nov 2 2023, 10:43 PM

Description

Steps to replicate the issue (include links if applicable):

Go to a diff links on a mobile site using Special:MobileDiff e.g. https://en.m.wikipedia.org/wiki/Special:MobileDiff/1181852947

NOTE: if on desktop resize your browser to around 400px.

What happens?:
A second set of 'Previous edit' and 'Next edit' links appear under the edit summary.

What should have happened instead?:
No duplicate links.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

IMG_20231102_221431.jpg (2×1 px, 259 KB)

QA

beta

Check only one set of previous and next links is shown on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileDiff/534765&diffonly=1

production

Check only one set of previous and next links is shown on https://en.m.wikipedia.org/wiki/Special:MobileDiff/1181852947

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: Duplicate diff navigation links on mobile	mediawiki/skins/MinervaNeue	master	+6 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T350539: on mobile mediawiki "go to previous edit" is duplicated

Event Timeline

Nintendofan885 created this task.Nov 2 2023, 10:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2023, 10:43 PM

Nintendofan885 updated the task description. (Show Details)Nov 2 2023, 10:44 PM

Nintendofan885 updated the task description. (Show Details)

Nintendofan885 updated the task description. (Show Details)Nov 2 2023, 10:47 PM

Novem_Linguae renamed this task from Duplicate diff navigation links of mobile to Duplicate diff navigation links on mobile.Nov 2 2023, 10:56 PM

Jdlrobson added projects: Web-Team-Backlog (Needs Prioritization (Tech)), MediaWiki-Page-diffs.Nov 3 2023, 2:19 AM

Can reproduce

Thanks for the bug report!

Jdlrobson updated the task description. (Show Details)Nov 3 2023, 5:05 PM

Change 971497 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Duplicate diff navigation links on mobile

https://gerrit.wikimedia.org/r/971497

gerritbot added a project: Patch-For-Review.Nov 3 2023, 5:08 PM

MobileFrontend already provides its own navigation links and now core navigation links are also being shown

Change 971497 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Duplicate diff navigation links on mobile

https://gerrit.wikimedia.org/r/971497

Jdlrobson renamed this task from Duplicate diff navigation links on mobile to Regression: Duplicate diff navigation links on mobile.Nov 3 2023, 6:18 PM

Jdlrobson added a project: Regression.

Jdlrobson updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2023, 6:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 3 2023, 7:00 PM

Frostly merged a task: T350539: on mobile mediawiki "go to previous edit" is duplicated.Nov 4 2023, 7:48 PM

Frostly added a subscriber: Effeietsanders.

Now fixed in production.

Jdlrobson added a project: Verified.Nov 9 2023, 7:59 PM

Regression: Duplicate diff navigation links on mobileClosed, ResolvedPublicBUG REPORTActions