Page MenuHomePhabricator

Users group - error message on attempting to Connect implementation needs to be placed closer to the button
Closed, ResolvedPublic

Assigned To
Authored By
Etonkovidova
Nov 10 2023, 1:34 AM
Referenced Files
F41930031: CleanShot 2024-02-16 at 15.58.29.gif
Feb 19 2024, 3:40 PM
F41930020: CleanShot 2024-02-16 at 15.56.01.gif
Feb 19 2024, 3:40 PM
F41514568: image.png
Nov 18 2023, 3:46 AM
F41514549: image.png
Nov 18 2023, 3:46 AM
F41514543: image.png
Nov 18 2023, 3:46 AM
F41480757: Screen Shot 2023-11-09 at 5.21.36 PM.png
Nov 10 2023, 1:34 AM

Description

Steps to reproduce:

  1. As a user in Users group, attempt to connect Implementation, e.g. https://wikifunctions.beta.wmflabs.org/view/en/Z10147)
  2. The error message is displayed at the bottom of the page and the page is not scrolled automatically to the error. It might be not obvious for a user to see the error message.
    Screen Shot 2023-11-09 at 5.21.36 PM.png (1×2 px, 276 KB)

Event Timeline

The error message is displayed on the right side on a large screen

image.png (851×1 px, 103 KB)

In a bit smaller screen
image.png (715×773 px, 60 KB)

I feel this would look good
image.png (740×1 px, 85 KB)

Change 975393 had a related patch set uploaded (by Punith.nyk; author: Punith.nyk):

[mediawiki/extensions/WikiLambda@master] Move the error message(User does not have permission to edit) closer to the button

https://gerrit.wikimedia.org/r/975393

Mcastro triaged this task as High priority.Feb 15 2024, 5:33 PM
Mcastro raised the priority of this task from High to Needs Triage.

i've tested this on beta/prod and we consistently display floating messages at the center-bottom of the screen.

success message bar after publish (gif)

CleanShot 2024-02-16 at 15.56.01.gif (499×800 px, 759 KB)

error message bar after trying to connect/disconnect an implementation/test (gif)

CleanShot 2024-02-16 at 15.58.29.gif (499×800 px, 552 KB)

the change of state (with a subtle fade in), might be enough to drive attention to the user. i've consulted the codex docs and we don't have clear guidance on where and how to display those messages.

my suggestion (for now) would be to keep this generic approach as is.

Change 975393 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Move the error message(User does not have permission to edit) closer to the button

Reason:

Over-taken by other code, but thank you!

https://gerrit.wikimedia.org/r/975393

Yeah, I agree this is good enough for now.