| Amire80 | |
| Mar 26 2024, 12:55 PM |
| F53609499: image.png | |
| Fri, May 17, 3:26 PM |
| F53609481: image.png | |
| Fri, May 17, 3:26 PM |
The message wikibase-monolingualtext has some HTML and ($1). It is optional and not translated to any languages. It can probably be completely removed. For languages that need different parentheses characters, there is the core MediaWiki message parentheses, and the HTML can be just constructed in the code in run time.
(The message is actually in WikibaseLib, but I couldn't find a project tag for that, so tagging as WikibaseRepository.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Replace wikibase-monolingualtext message with hard-coded HTML | mediawiki/extensions/Wikibase | master | +16 -7 |
Prio Notes:
| Impact Area | Affected |
|---|---|
| production / end users | ✘ |
| monitoring | ✘ |
| development efforts | ✘ |
| onboarding efforts | ✘ |
| additional stakeholders | ✔ |
Change #1032787 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace wikibase-monolingualtext message with hard-coded HTML
For languages that need different parentheses characters, there is the core MediaWiki message parentheses, and the HTML can be just constructed in the code in run time.
In the above patch I also used the word-separator message to replace the space between the two spans; do you think that makes sense, or should it be a hard-coded space after all? The first span isn’t necessarily in the user interface language, but to my naive eye, having no space before the full-width parenthesis still looks okay:
