Page MenuHomePhabricator
Create Task
Maniphest T363105

Refactored PayPal EC sends bad payments-init message on timeout
Closed, ResolvedPublic
Actions

Description

When paypal comes back with a timeout result code, we seem to send a message to payments-init without a country code, e.g. https://civicrm.wikimedia.org/civicrm/damaged/edit?id=627760

Details

SubjectRepoBranchLines +/-
PayPal EC: don't overwrite country with emptymediawiki/extensions/DonationInterfacemaster+3 -1
Fix log message for payments-init validationwikimedia/fundraising/crmmaster+1 -1
Customize query in gerrit

Event Timeline

Ejegg created this task.Mon, Apr 22, 3:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Apr 22, 3:09 PM
gerritbot added a comment.Mon, Apr 22, 3:11 PM

Change #1023094 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] PayPal EC: don't overwrite country with empty

https://gerrit.wikimedia.org/r/1023094

gerritbot added a project: Patch-For-Review.Mon, Apr 22, 3:11 PM
Ejegg renamed this task from Refactored PayPal EC sends bad payments-init message on timeout to Refactored PayPal EC sends bad payments-fraud message on timeout.Mon, Apr 22, 3:12 PM
Ejegg updated the task description. (Show Details)
Ejegg renamed this task from Refactored PayPal EC sends bad payments-fraud message on timeout to Refactored PayPal EC sends bad payments-init message on timeout.Mon, Apr 22, 3:15 PM
Ejegg updated the task description. (Show Details)
gerritbot added a comment.Mon, Apr 22, 3:15 PM

Change #1023096 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Fix log message for payments-init validation

https://gerrit.wikimedia.org/r/1023096

gerritbot added a comment.Mon, Apr 22, 8:13 PM

Change #1023096 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix log message for payments-init validation

https://gerrit.wikimedia.org/r/1023096

gerritbot added a comment.Mon, Apr 22, 9:38 PM

Change #1023094 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] PayPal EC: don't overwrite country with empty

https://gerrit.wikimedia.org/r/1023094

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Mon, Apr 22, 10:00 PM
AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Tue, Apr 23, 2:27 AM
greg assigned this task to Ejegg.Thu, Apr 25, 5:19 PM
greg triaged this task as Medium priority.
greg moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
Ejegg closed this task as Resolved.Thu, Apr 25, 8:05 PM
Ejegg moved this task from In Progress to Done on the Fundraising Tech - Chaos Crew board.

Hah, now it's got country but I'm seeing a missing payments_final_status

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL