Flagged Revision popup is not keyboard accessible or clickable
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	Fri, May 17, 2:41 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://ru.m.wikipedia.org/wiki/%D0%A5%D1%80%D0%B5%D0%B1%D0%B5%D1%82_%D0%9D%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%B0%D0%BA%D0%B0%D0%B4%D0%B5%D0%BC%D0%B8%D0%B8_%D0%BD%D0%B0%D1%83%D0%BA_%D0%A2%D0%B0%D0%B4%D0%B6%D0%B8%D0%BA%D0%B8%D1%81%D1%82%D0%B0%D0%BD%D0%B0
Hovering over view pending changes shows a popup
Try to click or tab via keyboard to the element instead.

What happens?:
Popup doesn't open

What should have happened instead?:
Popup should open on click or tab. e.g. behave consistently with other MediaWiki menus. Mobile devices should not rely on long press to display.

Screenshot 2024-05-17 at 7.42.07 AM.png (498×1 px, 116 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Use the standard details elements and we get that behaviour for free.

<details id="mw-fr-revisiontag" class="flaggedrevs_short flaggedrevs_draft_notsynced plainlinks noprint"><summary class="flaggedrevs_short_basic"><span class="flaggedrevs-icon flaggedrevs-icon-block skin-invert" title="Pending changes are displayed on this page"></span>[<a class="external text" href="https://ru.wikipedia.org/w/index.php?title=%D0%A5%D1%80%D0%B5%D0%B1%D0%B5%D1%82_%D0%9D%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%B0%D0%BA%D0%B0%D0%B4%D0%B5%D0%BC%D0%B8%D0%B8_%D0%BD%D0%B0%D1%83%D0%BA_%D0%A2%D0%B0%D0%B4%D0%B6%D0%B8%D0%BA%D0%B8%D1%81%D1%82%D0%B0%D0%BD%D0%B0&amp;oldid=131727408&amp;diff=cur">review pending changes</a>]<span class="fr-toggle-arrow flaggedrevs-icon flaggedrevs-icon-expand" id="mw-fr-revisiontoggle" title="show/hide details"></span></summary>
<div id="mw-fr-revisiondetails-wrapper" style="position:relative;"><div id="mw-fr-revisiondetails" class="flaggedrevs_short_details" style="display: block;"><a class="external text" href="https://ru.wikipedia.org/w/index.php?title=%D0%A5%D1%80%D0%B5%D0%B1%D0%B5%D1%82_%D0%9D%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%B0%D0%BA%D0%B0%D0%B4%D0%B5%D0%BC%D0%B8%D0%B8_%D0%BD%D0%B0%D1%83%D0%BA_%D0%A2%D0%B0%D0%B4%D0%B6%D0%B8%D0%BA%D0%B8%D1%81%D1%82%D0%B0%D0%BD%D0%B0&amp;oldid=131727408&amp;diff=cur">3 changes</a> in this version are <a href="/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%9F%D0%B0%D1%82%D1%80%D1%83%D0%BB%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5" title="Википедия:Патрулирование">pending review</a>.
The <a class="external text" href="https://ru.wikipedia.org/w/index.php?title=%D0%A5%D1%80%D0%B5%D0%B1%D0%B5%D1%82_%D0%9D%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%B0%D0%BA%D0%B0%D0%B4%D0%B5%D0%BC%D0%B8%D0%B8_%D0%BD%D0%B0%D1%83%D0%BA_%D0%A2%D0%B0%D0%B4%D0%B6%D0%B8%D0%BA%D0%B8%D1%81%D1%82%D0%B0%D0%BD%D0%B0&amp;stable=1">stable version</a> was <a class="external text" href="https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%96%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8B&amp;type=review&amp;page=%D0%A5%D1%80%D0%B5%D0%B1%D0%B5%D1%82_%D0%9D%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%B0%D0%BA%D0%B0%D0%B4%D0%B5%D0%BC%D0%B8%D0%B8_%D0%BD%D0%B0%D1%83%D0%BA_%D0%A2%D0%B0%D0%B4%D0%B6%D0%B8%D0%BA%D0%B8%D1%81%D1%82%D0%B0%D0%BD%D0%B0">checked</a> on <i>15 July 2023</i>.</div>
</div>
</details>

Related Objects

Mentioned In: T364587: FlaggedRevs notices became much bigger and more broken on mobile

Event Timeline

Jdlrobson created this task.Fri, May 17, 2:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 17, 2:41 PM

Jdlrobson updated the task description. (Show Details)Fri, May 17, 2:42 PM

Jdlrobson added subscribers: stjn, Tacsipacsi.

Jdlrobson mentioned this in T364587: FlaggedRevs notices became much bigger and more broken on mobile.Mon, May 20, 6:47 PM

The biggest problem with that piece of code is that it is just unnecessary. There is no benefit to hiding the FlaggedRevs info into a popup that repeats the same info that the non-hidden notice already provides. It would be very good to have someone simplify that piece of code but I know that FlaggedRevs isn’t well-maintained. I can provide simplified redesign ideas if there’s any chance of them getting implemented.

	F53606068: Screenshot 2024-05-17 at 7.42.07 AM.png
	Fri, May 17, 2:42 PM

Flagged Revision popup is not keyboard accessible or clickableOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Flagged Revision popup is not keyboard accessible or clickable
Open, Needs TriagePublicBUG REPORT
Actions