Page MenuHomePhabricator

Another really small LanguageHr.php update
Closed, InvalidPublic

Description

Author: elephantus

Description:
I had to transfer formatNum() code from the Russian language
LanguageRu.php to LanguageHr.php in order to make the
last patch http://bugzilla.wikimedia.org/show_bug.cgi?id=3656
(convertPlural()) work properly. This removes
the thousands separator from the number of articles, because
in Croatian this is a dot (instead of a comma in English)
and this confuses the convertPlural() function.

Thanks!


Version: unspecified
Severity: normal

Details

Reference
bz3701

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:52 PM
bzimport set Reference to bz3701.
bzimport added a subscriber: Unknown Object (MLST).

elephantus wrote:

Patch to remove the thousands separator

Attached:

avarab wrote:

(In reply to comment #1)

Created an attachment (id=992) [edit]
Patch to remove the thousands separator

You don't want to use $wgTranslateNumerals, it's only for language like Arabic
that have two widely used number format systems, which I understand is not the
case for Russian.

elephantus wrote:

Patch to remove the commafy() from the current file

This fixes the problem with convertPlural() in LanguageHr.php. It dumps the
thousands separator, but that's a price worth paying because
a wrong case looks just awful in Croatian, and a missing
separator is not that big an issue. :-)

Attached: