Page MenuHomePhabricator

Add swift authentication to video loader
ClosedPublic

Authored by Gilles on Mar 13 2018, 10:08 AM.

Details

Maniphest Tasks
T186528: Thumbor Swift authentication support for videos
Reviewers
fgiunchedi
Commits
rTHMBREXT9658da32528d: Add swift authentication to video loader
Patch without arc
git checkout -b D1004 && curl -L https://phabricator.wikimedia.org/D1004?download=true | git apply
Summary

Refs T186528

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Mar 13 2018, 10:08 AM
Gilles requested review of this revision.Mar 13 2018, 10:09 AM
fgiunchedi accepted this revision.Mar 13 2018, 11:06 AM

Not ideal to have secret data on the command line but AFAICS there isn't a way to use the environment in this case.

This revision is now accepted and ready to land.Mar 13 2018, 11:06 AM

Those expire quickly, afaik

This revision was automatically updated to reflect the committed changes.