Page MenuHomePhabricator

Add log extras to logger.exception call
ClosedPublic

Authored by Gilles on Mar 14 2018, 8:35 AM.

Details

Maniphest Tasks
T189647: Thumbor missing log extras when hitting ImageMagicException
Reviewers
fgiunchedi
Commits
rTHMBREXTa8e9d8d59f7e: Add log extras to logger.exception call
Patch without arc
git checkout -b D1007 && curl -L https://phabricator.wikimedia.org/D1007?download=true | git apply
Summary

Refs T189647

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Mar 14 2018, 8:35 AM
Gilles updated this revision to Diff 2637.Mar 14 2018, 8:47 AM

Revert to exception to get stack trace

@fgiunchedi FYI, CI is borked right now so you're not getting the code review notification

In D1007#20110, @Gilles wrote:

@fgiunchedi FYI, CI is borked right now so you're not getting the code review notification

doh! I can't even accept the revision. Anyways consider it accepted :)

This revision was not accepted when it landed; it landed in state Draft.Mar 15 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.