Differential D1007

Add log extras to logger.exception call
ClosedPublic
Actions

Authored by Gilles on Mar 14 2018, 8:35 AM.

Tags

None

Subscribers

Details

Maniphest Tasks

T189647: Thumbor missing log extras when hitting ImageMagicException

Reviewers

Commits

rTHMBREXTa8e9d8d59f7e: Add log extras to logger.exception call

Patch without arc

git checkout -b D1007 && curl -L https://phabricator.wikimedia.org/D1007?download=true | git apply

Summary

Diff Detail

Repository

rTHMBREXT Thumbor Plugins

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Mar 14 2018, 8:35 AM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1024/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1024/console

Harbormaster failed remote builds in B2844: Diff 2636!Mar 14 2018, 8:36 AM

Revert to exception to get stack trace

Harbormaster completed remote builds in B2845: Diff 2637.Mar 14 2018, 8:47 AM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1025/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1025/console

Harbormaster failed remote builds in B2845: Diff 2637!Mar 14 2018, 8:47 AM

@fgiunchedi FYI, CI is borked right now so you're not getting the code review notification

In D1007#20110, @Gilles wrote:

@fgiunchedi FYI, CI is borked right now so you're not getting the code review notification

doh! I can't even accept the revision. Anyways consider it accepted :)

This revision was not accepted when it landed; it landed in state Draft.Mar 15 2018, 9:01 AM

Closed by commit rTHMBREXTa8e9d8d59f7e: Add log extras to logger.exception call (authored by Gilles). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			wikimedia_thumbor/handler/images/images.py (2 lines)

Diff 2644

wikimedia_thumbor/handler/images/images.py

Loading...