Page MenuHomePhabricator

Python3 prep: Import StringIO from io and swap StringIO for BytesIO
AbandonedPublic

Authored by demon on Mar 28 2018, 4:36 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D1015 && curl -L https://phabricator.wikimedia.org/D1015?download=true | git apply
Summary

This at least gets all tests executing on python3, even if some are still failing. All tests still passing on Python2

Diff Detail

Event Timeline

demon created this revision.Mar 28 2018, 4:36 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptMar 28 2018, 4:36 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 80%] scap.tasks
highlighting module code... [ 85%] scap.template
highlighting module code... [ 90%] scap.terminal
highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1038/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1038/console

demon abandoned this revision.Mar 28 2018, 4:49 PM