Page MenuHomePhabricator

Improve logo on splash page for high-res screens
ClosedPublic

Authored by Krinkle on Apr 2 2018, 11:25 PM.

Details

Reviewers
bd808
Commits
R1922:4221e85000ad: Improve logo on splash page for high-res screens
Patch without arc
git checkout -b D1018 && curl -L https://phabricator.wikimedia.org/D1018?download=true | git apply
Summary
  • The PNG variant is a rendering for 1dppx, which looks blurry on high-DPI screens.
  • The SVG variant is smaller than a 1.5x or 2x PNG would be, and only marginally larger than the 1x PNG (10K vs 11K), so simply use the SVG always.
  • Where the PNG was cut to the edge, the SVG has some in-canvas spacing around the graphic. In order to keep rendering the same, change the image from 'mr-3' to 'mx-1', which effectively changes 'margin-right: 1rem' to 'margin-{left,right}: .25rem'.

Diff Detail

Repository
R1922 tool-admin-web
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Krinkle requested review of this revision.Apr 2 2018, 11:25 PM
Krinkle created this revision.
Krinkle added a reviewer: bd808.EditedApr 2 2018, 11:25 PM
BeforeAfter
bd808 accepted this revision.Apr 2 2018, 11:30 PM
This revision is now accepted and ready to land.Apr 2 2018, 11:30 PM
This revision was automatically updated to reflect the committed changes.