Add py3 to tox environments as non-voting
ClosedPublic
Actions

Authored by demon on Apr 3 2018, 8:25 PM.

Details

Reviewers

mmodell
thcipriani

Group Reviewers

Release-Engineering-Team

Commits

rMSCAc06d142eea83: Add py3 to tox environments as non-voting

Patch without arc

git checkout -b D1020 && curl -L https://phabricator.wikimedia.org/D1020?download=true | git apply

Diff Detail

Repository

rMSCA Scap

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Apr 3 2018, 8:25 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptApr 3 2018, 8:25 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster failed remote builds in B2880: Diff 2676!Apr 3 2018, 8:27 PM

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 85%] scap.template
highlighting module code... [ 90%] scap.terminal
highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
  py27: commands succeeded
ERROR:   py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1045/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1045/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/455/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/455/console

Also add py35 as an environment, skip missing interpreters

Harbormaster completed remote builds in B2883: Diff 2679.Apr 3 2018, 8:36 PM

demon requested review of this revision.Apr 3 2018, 8:36 PM

Note that Jessie has python3.4 ( https://packages.debian.org/search?keywords=python3 )

Add python3.4 too

Harbormaster completed remote builds in B2885: Diff 2681.Apr 4 2018, 6:43 PM

18:43:56   py27: commands succeeded
18:43:56   py34: ignored failed command
18:43:56 SKIPPED:  py35: InterpreterNotFound: python3.5
18:43:56 SKIPPED:  py36: InterpreterNotFound: python3.6
18:43:56   flake8: commands succeeded
18:43:56   doc: commands succeeded
18:43:56   congratulations :)

thcipriani accepted this revision.Apr 6 2018, 3:56 PM

This revision is now accepted and ready to land.Apr 6 2018, 3:56 PM

Closed by commit rMSCAc06d142eea83: Add py3 to tox environments as non-voting (authored by demon). · Explain WhyApr 6 2018, 7:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tox.ini (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2676	b786116		Apr 3 2018, 8:25 PM	★	★
Diff 2	2679	b786116	- Also add py35 as an environment, skip missing interpreters	Apr 3 2018, 8:34 PM	★	★
Diff 3	2681	b786116	- Add python3.4 too	Apr 4 2018, 6:41 PM	★	★
Diff 4	2693	16eba40	rMSCAc06d142eea83dfa9ca7429ff7ab285cbb2dca658	Apr 6 2018, 7:12 PM	★	★

Diff 2693

View Options

Add py3 to tox environments as non-votingClosedPublicActions