Page MenuHomePhabricator

Log check output when check succeeds.
ClosedPublic

Authored by mmodell on Apr 10 2018, 7:09 PM.

Details

Maniphest Tasks
T181071: Cache ORES virtualenv within versioned source
Reviewers
dduvall
awight
thcipriani
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCA0531edc1e064: Log check output when check succeeds.
rMSCA31b27fd44c6b: Log check output when check succeeds.
Patch without arc
git checkout -b D1026 && curl -L https://phabricator.wikimedia.org/D1026?download=true | git apply
Summary

Requested by @awight in T181071#4120819

Test Plan

untested

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mmodell created this revision.Apr 10 2018, 7:09 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptApr 10 2018, 7:09 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell requested review of this revision.Apr 10 2018, 7:11 PM

Thanks, looks good to me! Might be better to log at the "debug" level, if that's accessible to the user somehow.

mmodell updated this revision to Diff 2697.Apr 10 2018, 7:48 PM

use logger.debug()

debug level logs should be available with scap deploy-log -v

bump: Anyone care to review this?

dduvall accepted this revision.Apr 18 2018, 8:15 PM
This revision is now accepted and ready to land.Apr 18 2018, 8:15 PM
thcipriani accepted this revision.Apr 18 2018, 8:23 PM

lgtm!

Check 'say_hello' completed, output: HIIIII!

This revision was automatically updated to reflect the committed changes.