Page MenuHomePhabricator

Create separate public OAuth URL
AcceptedPublic

Authored by Tarrow on Apr 20 2018, 5:04 PM.

Details

Reviewers
Magnus
Patch without arc
git checkout -b D1028 && curl -L https://phabricator.wikimedia.org/D1028?download=true | git apply
Summary

In case the publically available OAuth url that the user uses differs from the privately available one QS uses in the back end make it possible to define this in config.json and pass it to the magnustools OAuth class.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Tarrow retitled this revision from WIP DNM - Create separate public OAuth URL to Create separate public OAuth URL.May 2 2018, 9:05 AM
Tarrow added a reviewer: Magnus.
Magnus added a comment.May 2 2018, 9:25 AM

"Patch without arc":

magnus@tools-bastion-03:~$ become quickstatements
tools.quickstatements@tools-bastion-03:~$ git checkout -b D1028 && curl -L https://phabricator.wikimedia.org/D1028?download=true | git apply
Switched to a new branch 'D1028'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   493  100   493    0     0   1485      0 --:--:-- --:--:-- --:--:--  1485
error: quickstatements.php: No such file or directory

I could just add the line by hand, but why doesn't this work the "official" way?

Tarrow added a comment.May 2 2018, 9:29 AM

Possibly I uploaded it wrong somehow.

I used the web uploader because I also didn't have arc. It should be
editing the file in public_html not the root... This was the first time I
used differential so perhaps I missed a path somewhere.

Magnus accepted this revision.May 2 2018, 9:39 AM

In master now

This revision is now accepted and ready to land.May 2 2018, 9:39 AM
Tarrow added a comment.May 2 2018, 9:40 AM

Thanks!

That was amazingly fast :)