Page MenuHomePhabricator

Store more than ssh info in case of errors
ClosedPublic

Authored by thcipriani on Apr 23 2018, 10:24 PM.

Details

Reviewers
mmodell
dduvall
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCA2d6d525cb3d1: Store more than ssh info in case of errors
Patch without arc
git checkout -b D1030 && curl -L https://phabricator.wikimedia.org/D1030?download=true | git apply
Summary

Currently when we get logs from a target we parse them pass them to the
default log handlers. The command-line log handers are silenced for
targets because it would be a ton of noise. Instead we save all logs to
the scap/logs/*.log files; however, in the case that a target fails when
running an ssh command we dump the output from that target to the cli.

That output used to be empty, except now when you pass -v you also are
passing -v to the underlying ssh commands. As a result the output is all
the ssh session information. This makes it look like there was some ssh
problem when, in fact, something else went wrong on the target.

Rather than try to silence the ssh output, lets just dump all the output
from remote command that failed.

Bug: T182623

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Apr 23 2018, 10:24 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptApr 23 2018, 10:24 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani updated this revision to Diff 2708.Apr 24 2018, 3:02 PM

Resubmitting. Jenkins build failed due to being out of disk space on agent.

thcipriani requested review of this revision.Apr 24 2018, 3:04 PM
mmodell accepted this revision.Apr 24 2018, 3:20 PM
This revision is now accepted and ready to land.Apr 24 2018, 3:20 PM
This revision was automatically updated to reflect the committed changes.