Page MenuHomePhabricator

MediaWiki Canaries: use swagger spec

Authored by thcipriani on Apr 24 2018, 4:44 PM.


Group Reviewers
rMSCAda3ba1d54f68: MediaWiki Canaries: use swagger spec
Patch without arc
git checkout -b D1031 && curl -L | git apply

In addition to checking logstash for sudden increases in error-rate,
MediaWiki deployments should be able to query a known set of endpoints
for expected responses. Since this is exactly what
service-checker-swagger does for services given a url, host, and spec
path we can shell out to that as part of a deployment.

Bug: T136839

Diff Detail

rMSCA Scap
Lint Not Applicable
Tests Not Applicable

Event Timeline

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

reading sources... [ 63%] scap3/config
reading sources... [ 68%] scap3/deploy_commands
reading sources... [ 73%] scap3/index
reading sources... [ 78%] scap3/quickstart/deployer
reading sources... [ 84%] scap3/quickstart/index
reading sources... [ 89%] scap3/quickstart/setup
reading sources... [ 94%] scap3/repo_config
reading sources... [100%] scap3/ssh-access

Warning, treated as error:
/srv/jenkins-workspace/workspace/phabricator-jessie-diffs/scap/ of scap.main.AbstractSync.canary_checks:4:Field list ends without a blank line; unexpected unindent.
ERROR: InvocationError: '/srv/jenkins-workspace/workspace/phabricator-jessie-diffs/.tox/doc/bin/sphinx-build -W -b html docs/ docs/_build/html'
___________________________________ summary ____________________________________
  py27: commands succeeded
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
ERROR:   doc: commands failed

Link to build:
See console output for more information:

Forgot a colon in the docstring

Url needs to have "http" otherwise service-checker-swagger fails

This revision is now accepted and ready to land.Apr 24 2018, 5:30 PM

Merge and then test on beta? We can revert if it breaks things terribly.

Merge and then test on beta? We can revert if it breaks things terribly.

Yeah, lemme create the matching puppet patch for this and then it should be good to land.

This revision was automatically updated to reflect the committed changes.