Details

Reviewers

mmodell
thcipriani

Group Reviewers

Release-Engineering-Team

Commits

rMSCAfcfd07a339e9: test_log.py: Swap for io.StringIO

Patch without arc

git checkout -b D1033 && curl -L https://phabricator.wikimedia.org/D1033?download=true | git apply

Summary

Works in both Py3 and Py2 sucessfully. There's a few other StringIO uses in the tests, but they don't swap as cleanly

Diff Detail

Repository

rMSCA Scap

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Apr 28 2018, 10:20 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptApr 28 2018, 10:20 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster failed remote builds in B2929: Diff 2715!Apr 28 2018, 10:20 PM

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/470/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/470/console

Got test_ssh.py working too
Fix remainder of tests, mostly

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/console

Harbormaster failed remote builds in B2930: Diff 2716!Apr 28 2018, 10:40 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/471/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/471/console

Fixing StringIO usage?

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/console

Harbormaster failed remote builds in B2931: Diff 2717!Apr 28 2018, 10:47 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/472/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/472/console

Try again

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/console

Harbormaster failed remote builds in B2932: Diff 2718!Apr 28 2018, 10:51 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/473/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/473/console

Unicodes for checks.py

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/console

Harbormaster failed remote builds in B2933: Diff 2719!Apr 28 2018, 10:54 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/474/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/474/console

Unicode everywhere

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/console

Harbormaster failed remote builds in B2934: Diff 2720!Apr 28 2018, 11:55 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/475/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/475/console

Narrowed scope to just handle test_log.py, easy fixes

Remove test_checks.py fix, mistake

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/console

demon retitled this revision from test_checks.py: Swap for io.StringIO to test_log.py: Swap for io.StringIO.Apr 30 2018, 6:19 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/476/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/476/console

Harbormaster failed remote builds in B2935: Diff 2721!Apr 30 2018, 6:20 PM

Harbormaster completed remote builds in B2936: Diff 2722.

demon requested review of this revision.Apr 30 2018, 6:22 PM

thcipriani accepted this revision.May 1 2018, 4:32 PM

This revision is now accepted and ready to land.May 1 2018, 4:32 PM

Closed by commit rMSCAfcfd07a339e9: test_log.py: Swap for io.StringIO (authored by demon). · Explain WhyMay 1 2018, 8:38 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2715	c06d142		Apr 28 2018, 10:20 PM	★	★
Diff 2	2716	c06d142	- Got test_ssh.py working too	Apr 28 2018, 10:38 PM	★	★
Diff 3	2717	c06d142	- Fixing StringIO usage?	Apr 28 2018, 10:46 PM	★	★
Diff 4	2718	c06d142	- Try again	Apr 28 2018, 10:49 PM	★	★
Diff 5	2719	c06d142	- Unicodes for checks.py	Apr 28 2018, 10:53 PM	★	★
Diff 6	2720	c06d142	- Unicode everywhere	Apr 28 2018, 11:54 PM	★	★
Diff 7	2721	2d6d525	- Narrowed scope to just handle test_log.py, easy fixes	Apr 30 2018, 6:18 PM	★	★
Diff 8	2722	2d6d525	- Remove test_checks.py fix, mistake	Apr 30 2018, 6:19 PM	★	★
Diff 9	2729	c275f78	rMSCAfcfd07a339e9ec9efecf3d03db9eef53fa1a1dce	May 1 2018, 8:37 PM	★	★

test_log.py: Swap for io.StringIO
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

Revision Contents
Changeset List

Diff 2729

tests/scap/test_log.py

test_log.py: Swap for io.StringIOClosedPublicActions

Details

Diff Detail

Event Timeline

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

tox -v log

Revision ContentsChangeset List

Diff 2729

tests/scap/test_log.py

test_log.py: Swap for io.StringIO
ClosedPublic
Actions

Revision Contents
Changeset List