Page MenuHomePhabricator
Differential D1033

test_log.py: Swap for io.StringIO
ClosedPublic
Actions

Authored by demon on Apr 28 2018, 10:20 PM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCAfcfd07a339e9: test_log.py: Swap for io.StringIO
Patch without arc
git checkout -b D1033 && curl -L https://phabricator.wikimedia.org/D1033?download=true | git apply
Summary

Works in both Py3 and Py2 sucessfully. There's a few other StringIO uses in the tests, but they don't swap as cleanly

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Apr 28 2018, 10:20 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptApr 28 2018, 10:20 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
Harbormaster failed remote builds in B2929: Diff 2715!Apr 28 2018, 10:20 PM
jenkins added a subscriber: jenkins.Apr 28 2018, 10:21 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/console

jenkins added a comment.Apr 28 2018, 10:21 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/470/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/470/console

demon updated this revision to Diff 2716.Apr 28 2018, 10:38 PM
  • Got test_ssh.py working too
  • Fix remainder of tests, mostly
jenkins added a comment.Apr 28 2018, 10:40 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/console

Harbormaster failed remote builds in B2930: Diff 2716!Apr 28 2018, 10:40 PM
jenkins added a comment.Apr 28 2018, 10:40 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/471/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/471/console

demon updated this revision to Diff 2717.Apr 28 2018, 10:46 PM
  • Fixing StringIO usage?
jenkins added a comment.Apr 28 2018, 10:47 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/console

Harbormaster failed remote builds in B2931: Diff 2717!Apr 28 2018, 10:47 PM
jenkins added a comment.Apr 28 2018, 10:48 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/472/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/472/console

demon updated this revision to Diff 2718.Apr 28 2018, 10:49 PM
  • Try again
jenkins added a comment.Apr 28 2018, 10:51 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/console

Harbormaster failed remote builds in B2932: Diff 2718!Apr 28 2018, 10:51 PM
jenkins added a comment.Apr 28 2018, 10:51 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/473/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/473/console

demon updated this revision to Diff 2719.Apr 28 2018, 10:53 PM
  • Unicodes for checks.py
jenkins added a comment.Apr 28 2018, 10:54 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/console

Harbormaster failed remote builds in B2933: Diff 2719!Apr 28 2018, 10:54 PM
jenkins added a comment.Apr 28 2018, 10:55 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/474/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/474/console

demon updated this revision to Diff 2720.Apr 28 2018, 11:54 PM
  • Unicode everywhere
jenkins added a comment.Apr 28 2018, 11:55 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/console

Harbormaster failed remote builds in B2934: Diff 2720!Apr 28 2018, 11:55 PM
jenkins added a comment.Apr 28 2018, 11:55 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/475/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/475/console

demon updated this revision to Diff 2721.Apr 30 2018, 6:18 PM
  • Narrowed scope to just handle test_log.py, easy fixes
demon updated this revision to Diff 2722.Apr 30 2018, 6:19 PM
  • Remove test_checks.py fix, mistake
jenkins added a comment.Apr 30 2018, 6:19 PM

Build has FAILED

Test Name
tox -vBuild Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
ERROR:   py27: commands failed
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  flake8: commands succeeded
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/console

demon retitled this revision from test_checks.py: Swap for io.StringIO to test_log.py: Swap for io.StringIO.Apr 30 2018, 6:19 PM
jenkins added a comment.Apr 30 2018, 6:20 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/476/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/476/console

Harbormaster failed remote builds in B2935: Diff 2721!Apr 30 2018, 6:20 PM
Harbormaster completed remote builds in B2936: Diff 2722.
demon requested review of this revision.Apr 30 2018, 6:22 PM
thcipriani accepted this revision.May 1 2018, 4:32 PM
This revision is now accepted and ready to land.May 1 2018, 4:32 PM
Closed by commit rMSCAfcfd07a339e9: test_log.py: Swap for io.StringIO (authored by demon). · Explain WhyMay 1 2018, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
scap/
18 lines

Diff 2729

View Options

tests/scap/test_log.py

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL