Works in both Py3 and Py2 sucessfully. There's a few other StringIO uses in the tests, but they don't swap as cleanly
Details
- Reviewers
mmodell thcipriani - Group Reviewers
Release-Engineering-Team - Commits
- rMSCAfcfd07a339e9: test_log.py: Swap for io.StringIO
- Patch without arc
- git checkout -b D1033 && curl -L https://phabricator.wikimedia.org/D1033?download=true | git apply
Diff Detail
- Repository
- rMSCA Scap
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1064/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/470/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/470/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1065/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/471/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/471/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1066/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/472/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/472/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1067/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/473/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/473/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1068/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/474/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/474/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1069/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/475/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/475/console
Build has FAILED
Test Name | ||
tox -v | Build Details | |
tox -v log
Got exit code 1 from PY_COLORS=1 tox -v
highlighting module code... [ 95%] scap.utils highlighting module code... [100%] time writing additional pages... search copying images... [100%] assets/images/deploy-log.gif copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded. The HTML pages are in docs/_build/html. ___________________________________ summary ____________________________________ ERROR: py27: commands failed py34: ignored failed command SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 flake8: commands succeeded doc: commands succeeded
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1070/console
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/476/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/476/console