- Use byte-array in a couple of places instead of str
- Python3 folded IOError into OSError, so just throw OSError instead
WIP because I haven't gotten py_djb_hash()'s doctest working yet in py3
Details
Details
- Reviewers
mmodell thcipriani - Group Reviewers
Release-Engineering-Team - Commits
- rMSCAcd15f2d78712: WIP: cdblib: Fix py2/py3 compat
- Patch without arc
- git checkout -b D1036 && curl -L https://phabricator.wikimedia.org/D1036?download=true | git apply
Diff Detail
Diff Detail
- Repository
- rMSCA Scap
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| scap/cdblib.py | ||
|---|---|---|
| 82 | Probably should vary here as well. | |
Comment Actions
- Actually fix DJB hash func now
Because of the wide range of inputs we allow, we can easily end up in a weird state of byte arrays or strings. So variably use ord() depending on what we need
Comment Actions
reverted saturday. Causing scap to fail. I think due to the data = data.encode('utf-8') on line 82.