cdblib: More YAGNI removals
ClosedPublic

Authored by demon on May 1 2018, 9:45 PM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA759961f69952: cdblib: More YAGNI removals
Patch without arc
git checkout -b D1038 && curl -L https://phabricator.wikimedia.org/D1038?download=true | git apply
Summary
  • Writer.puts(): We don't actually put things in a loop anywhere
  • Reader: Various iterable features that we don't make use of

In theory, all useful, but we don't use them and we want CDB gone from here eventually

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.May 1 2018, 9:45 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptMay 1 2018, 9:45 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.May 1 2018, 9:47 PM
thcipriani accepted this revision.May 1 2018, 9:53 PM
This revision is now accepted and ready to land.May 1 2018, 9:53 PM
This revision was automatically updated to reflect the committed changes.