do `git lfs install` before `git lfs pull`
ClosedPublic

Authored by mmodell on May 1 2018, 11:25 PM.

Details

Maniphest Tasks
T180627: Support git-lfs in scap
Reviewers
demon
thcipriani
awight
Group Reviewers
Release-Engineering-Team
Commits
rMSCAf8ecbd12a5c6: do `git lfs install` before `git lfs pull`
Patch without arc
git checkout -b D1039 && curl -L https://phabricator.wikimedia.org/D1039?download=true | git apply
Summary

This should be the final piece to get git-lfs working in production.

Test Plan

it works, trust me?

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmodell created this revision.May 1 2018, 11:25 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMay 1 2018, 11:25 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell requested review of this revision.May 1 2018, 11:27 PM

@thcipriani: it would be super cool if we can squeeze this into the next scap release, assuming you haven't cut that branch already.

mmodell retitled this revision from do `git fat install` before `git fat pull` to do `git lfs install` before `git lfs pull`.May 1 2018, 11:32 PM
thcipriani accepted this revision.May 1 2018, 11:32 PM
This revision is now accepted and ready to land.May 1 2018, 11:32 PM
This revision was automatically updated to reflect the committed changes.

I confirmed that this will *not* work as we hope. If git lfs install is executed before the initial clone, then LFS files are fetched during the initial clone. git lfs pull is normally only used if the initial clone is done with --skip-smudge enabled (see https://github.com/git-lfs/git-lfs/wiki/Installation). Calling git lfs install after the repo is already cloned doesn't actually cause the right stuff to happen.

This is the correct workflow:

  • git lfs install
  • git clone REPO
  • cd REPO
  • git submodule update -i