Unify stats increment calls in sync operations
ClosedPublic

Authored by demon on May 4 2018, 1:42 AM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA990d859fe9ff: Unify stats increment calls in sync operations
Patch without arc
git checkout -b D1043 && curl -L https://phabricator.wikimedia.org/D1043?download=true | git apply

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.May 4 2018, 1:42 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptMay 4 2018, 1:42 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.May 4 2018, 1:44 AM
mmodell accepted this revision.May 4 2018, 7:33 PM
This revision is now accepted and ready to land.May 4 2018, 7:33 PM

One nitpick.

scap/main.py
810

This changes the name of this stat.

demon added inline comments.May 4 2018, 8:06 PM
scap/main.py
810

I know, but I wanted to get it consistent with everything else. Also note the addition of deploy.all happening here too.

This revision was automatically updated to reflect the committed changes.