Consistent return statements on functions that already have them
ClosedPublic

Authored by demon on May 4 2018, 7:24 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCAe53eb281f4b7: Consistent return statements on functions that already have them
Patch without arc
git checkout -b D1045 && curl -L https://phabricator.wikimedia.org/D1045?download=true | git apply
Summary

Really we should be more consistent with return codes everywhere, but at least be consistent in functions that do return them (pylint complains otherwise)

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.May 4 2018, 7:24 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptMay 4 2018, 7:24 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.May 4 2018, 7:28 PM
mmodell accepted this revision.May 4 2018, 7:29 PM
This revision is now accepted and ready to land.May 4 2018, 7:29 PM
This revision was automatically updated to reflect the committed changes.