Unconditionally copy npm-shrinkwrap.json
AbandonedPublic

Authored by akosiaris on May 19 2018, 4:27 PM.

Details

Reviewers
dduvall
thcipriani
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D1056 && curl -L https://phabricator.wikimedia.org/D1056?download=true | git apply
Summary

npm-shrinkwrap.json is a file used by npm to lock version dependencies.
This is required by graphoid to build correctly currently, due to some
decisions taken in the past about some code dependencies by one of the
libraries.

Unfortunately this is going to break things. If docker does not find
this file during the building process it is going to fail

Diff Detail

Repository
rGBLBR Blubber
Lint
Lint Skipped
Unit
Unit Tests Skipped
akosiaris created this revision.May 19 2018, 4:27 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMay 19 2018, 4:27 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
akosiaris requested review of this revision.May 19 2018, 4:27 PM

I've uploaded D1058: Refactor config for node app dependencies which I think is a more complete implementation of what we discussed.

Looking at rGBLBRfdcd9be3c96a686d530859b4f777ea5b45cf5eda I don't see a mention of npm-shrinkwrap.json in any other place than the commit message. Am I missing something ?

Looking at rGBLBRfdcd9be3c96a686d530859b4f777ea5b45cf5eda I don't see a mention of npm-shrinkwrap.json in any other place than the commit message. Am I missing something ?

Instead of having:

node: {requirements: true}

as a flag, rGBLBRfdcd9be3c96a686d530859b4f777ea5b45cf5eda makes requirements a list of files. So including npm-shrinkwrap.json would looks like:

node:
  requirements:
    - package.json
    - npm-shrinkwrap.json

Now just a list of files to copy into the /opt/lib directory prior to running npm install.

akosiaris abandoned this revision.May 25 2018, 8:12 AM

Looking at rGBLBRfdcd9be3c96a686d530859b4f777ea5b45cf5eda I don't see a mention of npm-shrinkwrap.json in any other place than the commit message. Am I missing something ?

Instead of having:

node: {requirements: true}

as a flag, rGBLBRfdcd9be3c96a686d530859b4f777ea5b45cf5eda makes requirements a list of files. So including npm-shrinkwrap.json would looks like:

node:
  requirements:
    - package.json
    - npm-shrinkwrap.json

Now just a list of files to copy into the /opt/lib directory prior to running npm install.

Ah nice. I guess we should document that. Closing this, thanks!