Differential D1059

Cross-compile using gox
ClosedPublic
Actions

Authored by thcipriani on May 19 2018, 8:43 PM.

Tags

Subscribers

None

Details

Reviewers

Group Reviewers

Release-Engineering-Team

Commits

rGBLBRb0e3e7d8a55f: Cross-compile using gox

Patch without arc

git checkout -b D1059 && curl -L https://phabricator.wikimedia.org/D1059?download=true | git apply

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.May 19 2018, 8:43 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMay 19 2018, 8:43 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

thcipriani requested review of this revision.May 19 2018, 8:43 PM

thcipriani updated this revision to Diff 2784.May 19 2018, 9:08 PM

On macOS: /bin/sh: sha256sum: command not found. :(

dduvall added inline comments.May 24 2018, 5:07 PM

Makefile
17	A very cursory search says `shasum -a 256` might be more cross platform.

Use shasum -a 256

Harbormaster completed remote builds in B3005: Diff 2791.May 24 2018, 6:03 PM

thcipriani marked an inline comment as done.May 24 2018, 6:03 PM

Works for me!

This revision is now accepted and ready to land.May 24 2018, 6:07 PM

Closed by commit rGBLBRb0e3e7d8a55f: Cross-compile using gox (authored by thcipriani). · Explain WhyMay 24 2018, 6:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			.gitignore (1 line)
M			CONTRIBUTING.md (9 lines)
M			Makefile (12 lines)

Diff 2792

.gitignore

Loading...

CONTRIBUTING.md

Loading...

Makefile

Loading...