Support timestamp based consumption via Last-Event-ID header
ClosedPublic
Actions

Authored by Ottomata on May 30 2018, 7:55 PM.

Details

Reviewers

Pchelolo
Ottomata

Commits

Patch without arc

git checkout -b D1063 && curl -L https://phabricator.wikimedia.org/D1063?download=true | git apply

Summary

This updates to node-rdkafka 2.3.3 and bumps KafkaSSE version to 0.2.0.

Repository

rWKSE KafkaSSE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Ottomata requested review of this revision.May 30 2018, 7:58 PM

Hold on review. I have another patch coming as soon as I get tests to pass.

Dockerfile
15	Why do we have a committed Dockerfile? Other services gitignore it and generate it using the service-runner deploy script..
README.md
20	`A assignments` doesn't sound right.
200	There's a missing space.
test/KafkaSSE.js
237	This is probably not needed.

Ottomata marked 3 inline comments as done.Jun 4 2018, 3:59 PM

Ottomata added inline comments.

Dockerfile
15	KafkaSSE does not use service-runner. This is a standalone library. The Dockerfile is used for tests.

This revision is now accepted and ready to land.Jun 4 2018, 4:30 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			Dockerfile (3 lines)
M			README.md (12 lines)
M			client.js (43 lines)
M			index.js (30 lines)
M			lib/KafkaSSE.js (109 lines)
M			lib/utils.js (190 lines)
M			package.json (10 lines)
M			server.js (9 lines)
M			test/KafkaSSE.js (24 lines)
M			test/docker/kafka/dockerfile (2 lines)
M			test/utils.js (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2798	d6d9a97		May 30 2018, 7:55 PM	★	★
Diff 2	2803	d6d9a97	- Simplify offset/timestamp assignment resolution	Jun 1 2018, 3:41 PM	★	★
Diff 3	2804	d6d9a97	- Fix review coments	Jun 4 2018, 4:10 PM	★	★
Diff 4	2805	d6d9a97	rWKSE25935735308ca2956f5c66769cf00d5b15434bc6	Jun 4 2018, 4:30 PM	★	★