Paths

Table of Contentst

Differential D1063

Support timestamp based consumption via Last-Event-ID header
ClosedPublic
Actions

Authored by Ottomata on May 30 2018, 7:55 PM.

Tags

None

Subscribers

None

Details

Reviewers

Pchelolo
Ottomata

Commits

rWKSE25935735308c: Support timestamp based consumption via Last-Event-ID header

Patch without arc

git checkout -b D1063 && curl -L https://phabricator.wikimedia.org/D1063?download=true | git apply

Summary

This updates to node-rdkafka 2.3.3 and bumps KafkaSSE version to 0.2.0.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Ottomata created this revision.May 30 2018, 7:55 PM

Harbormaster completed remote builds in B3009: Diff 2798.May 30 2018, 7:58 PM

Ottomata requested review of this revision.May 30 2018, 7:58 PM

Ottomata added a reviewer: Pchelolo.May 30 2018, 8:02 PM

Hold on review. I have another patch coming as soon as I get tests to pass.

Simplify offset/timestamp assignment resolution

Harbormaster completed remote builds in B3013: Diff 2803.Jun 1 2018, 3:43 PM

Pchelolo added inline comments.Jun 4 2018, 2:23 PM

Dockerfile
15	Why do we have a committed Dockerfile? Other services gitignore it and generate it using the service-runner deploy script..
README.md
19	`A assignments` doesn't sound right.
200	There's a missing space.
test/KafkaSSE.js
236	This is probably not needed.

Ottomata marked 3 inline comments as done.Jun 4 2018, 3:59 PM

Ottomata added inline comments.

Dockerfile
15	KafkaSSE does not use service-runner. This is a standalone library. The Dockerfile is used for tests.

Fix review coments

Harbormaster completed remote builds in B3014: Diff 2804.Jun 4 2018, 4:13 PM

Ottomata accepted this revision.Jun 4 2018, 4:30 PM

This revision is now accepted and ready to land.Jun 4 2018, 4:30 PM

Closed by commit rWKSE25935735308c: Support timestamp based consumption via Last-Event-ID header (authored by Ottomata). · Explain WhyJun 4 2018, 4:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

3 lines

12 lines

43 lines

30 lines

lib/

109 lines

190 lines

10 lines

9 lines

test/

24 lines

docker/

kafka/

2 lines

26 lines

Diff 2805

Dockerfile

Loading...

README.md

Loading...

client.js

Loading...

index.js

Loading...

lib/KafkaSSE.js

Loading...

lib/utils.js

Loading...

package.json

Loading...

server.js

Loading...

test/KafkaSSE.js

Loading...

test/docker/kafka/dockerfile

Loading...

test/utils.js

Loading...