Ignore refs/changes/**/**/meta
ClosedPublic

Authored by Paladox on Jun 10 2018, 9:56 PM.

Details

Maniphest Tasks
T196891: Recent "Update patch set 1" notifications from Diffusion
T196855: Diffusion commits stuck in 'Importing...
T196840: Massive increase of writes in m3 section
T196860: Ignore refs/changes/**/**/meta
Reviewers
mmodell
hashar
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D1067 && curl -L https://phabricator.wikimedia.org/D1067?download=true | git apply
Summary

Due to a recent gerrit upgrade, gerrit has moved comments from the db into a git style commit which is causing high load on the phabricator db and cpu.

Change-Id: I5cf15cee57c44cbb49435c8145c6bdf0bf53334e

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint SkippedExcuse: Same as before
Unit
Unit Tests Skipped
Build Status
Buildable 3022
Build 5059: arc lint + arc unit
Paladox created this revision.Jun 10 2018, 9:56 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptJun 10 2018, 9:56 PM
Paladox requested review of this revision.Jun 10 2018, 9:56 PM

I haven't tested this so not sure if it will work.

Paladox updated this revision to Diff 2809.Jun 10 2018, 10:32 PM

This new patchset has been tested and works.

I've tested this and works here https://phab.wmflabs.org/diffusion/7/ notice that it shows smaller amount of refs compared to https://phabricator.wikimedia.org/diffusion/SMTL/

Will this ignore this kind of commits from now on or does it fix the issue for good? (ie: no need to delete refs/changes/*/*/meta afterwards?)

Will this ignore this kind of commits from now on or does it fix the issue for good? (ie: no need to delete refs/changes/*/*/meta afterwards?)

It will prevent any new commits under this ref but I am not sure if it will delete the existing ones.

hashar accepted this revision.Jun 11 2018, 4:48 PM
This revision is now accepted and ready to land.Jun 11 2018, 4:48 PM

@mmodell Looks good to me. Gerrit is migrating notes from the database toward the git repositories: https://www.gerritcodereview.com/releases/2.15.md#NoteDb-for-Changes

mmodell accepted this revision.Jun 11 2018, 4:55 PM