Handle video custom aspect ratios/non-square pixels
ClosedPublic

Authored by Gilles on Jun 25 2018, 1:21 PM.

Details

Maniphest Tasks
T198043: Thumbor thumbnails for WebM & Ogg videos with non square pixels have wrong aspect ratio
Reviewers
brion
fgiunchedi
Commits
rTHMBREXT25dd4de9422c: Handle video custom aspect ratios/non-square pixels
Patch without arc
git checkout -b D1072 && curl -L https://phabricator.wikimedia.org/D1072?download=true | git apply
Summary

Refs T198043

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Gilles created this revision.Jun 25 2018, 1:21 PM
Gilles requested review of this revision.Jun 25 2018, 1:22 PM

LGTM, any chance we could include a smaller/shorter test video though? I take it the test isn't affected by video length

LGTM, any chance we could include a smaller/shorter test video though? I take it the test isn't affected by video length

I'll try to shorten this one

Gilles updated this revision to Diff 2818.Jun 26 2018, 8:20 AM

Smaller cat

fgiunchedi accepted this revision.Jun 26 2018, 8:24 AM

+1 for smaller cat

This revision is now accepted and ready to land.Jun 26 2018, 8:24 AM
This revision was automatically updated to reflect the committed changes.