Refactor canary_checks method
ClosedPublic

Authored by thcipriani on Jul 10 2018, 2:22 PM.

Details

Reviewers
mmodell
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rMSCA97f4de769281: Refactor canary_checks method
Patch without arc
git checkout -b D1079 && curl -L https://phabricator.wikimedia.org/D1079?download=true | git apply
Summary

Currently canary_checks syncs canaries and then checks canaries. These
should be two different methods so that we can use canary_checks to
verify things other than just syncing.

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thcipriani created this revision.Jul 10 2018, 2:22 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptJul 10 2018, 2:22 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Jul 10 2018, 2:23 PM
mmodell accepted this revision.Jul 10 2018, 6:32 PM

Looks good to me.

This revision is now accepted and ready to land.Jul 10 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.