Differential D1086

Fix path to batch summary
ClosedPublic
Actions

Authored by matej_suchanek on Jul 24 2018, 11:55 AM.

Details

Reviewers

Magnus

Patch without arc

git checkout -b D1086 && curl -L https://phabricator.wikimedia.org/D1086?download=true | git apply

Diff Detail

Repository

R2010 tool-quickstatements

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

matej_suchanek requested review of this revision.Jul 24 2018, 11:55 AM

matej_suchanek created this revision.

Magnus accepted this revision.Jul 24 2018, 11:56 AM

This revision is now accepted and ready to land.Jul 24 2018, 11:56 AM

Why is patching with Differential so crappy?

tools.quickstatements@tools-bastion-03:~$ git checkout -b D1086 && curl -L https://phabricator.wikimedia.org/D1086?download=true | git apply
Switched to a new branch 'D1086'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1677  100  1677    0     0   4669      0 --:--:-- --:--:-- --:--:--  4669
error: patch failed: public_html/quickstatements.js:440
error: public_html/quickstatements.js: patch does not apply
error: patch failed: public_html/quickstatements.php:238
error: public_html/quickstatements.php: patch does not apply

Might have been error on my side. Reuploaded.

Thanks, applied!

Magnus closed this revision.Jul 24 2018, 12:16 PM

Magnus mentioned this in R2010:d1bb53f9ac68: Patch D1086 by matej_suchanek.Jul 24 2018, 12:17 PM

matej_suchanek awarded a token.Jul 24 2018, 12:18 PM